Commit a2b77dce authored by Mark Brown's avatar Mark Brown Committed by Florian Tobias Schandinat
Browse files

video: s3c-fb: Use s3c_fb_enable() to enable the framebuffer 



The s3c-fb driver has a function called s3c_fb_enable() which turns on
and off the physical output. However it is only actually used in paths
which disable the screen, the enabling just writes to the register. Make
the code less confusing by ensuring that the enable also goes through
the same path.

Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
parent fe05f8b1

drivers/video/s3c-fb.c

+28 −27
Original line number Diff line number Diff line
@@ -440,6 +440,32 @@ static void shadow_protect_win(struct s3c_fb_win *win, bool protect) 
	}

}



/**

 * s3c_fb_enable() - Set the state of the main LCD output

 * @sfb: The main framebuffer state.

 * @enable: The state to set.

 */

static void s3c_fb_enable(struct s3c_fb *sfb, int enable)

{

	u32 vidcon0 = readl(sfb->regs + VIDCON0);



	if (enable)

		vidcon0 |= VIDCON0_ENVID | VIDCON0_ENVID_F;

	else {

		/* see the note in the framebuffer datasheet about

		 * why you cannot take both of these bits down at the

		 * same time. */



		if (!(vidcon0 & VIDCON0_ENVID))

			return;



		vidcon0 |= VIDCON0_ENVID;

		vidcon0 &= ~VIDCON0_ENVID_F;

	}



	writel(vidcon0, sfb->regs + VIDCON0);

}



/**

 * s3c_fb_set_par() - framebuffer request to set new framebuffer state.

 * @info: The framebuffer to change.
@@ -510,9 +536,10 @@ static int s3c_fb_set_par(struct fb_info *info) 
		if (sfb->variant.is_2443)

			data |= (1 << 5);



		data |= VIDCON0_ENVID | VIDCON0_ENVID_F;

		writel(data, regs + VIDCON0);



		s3c_fb_enable(sfb, 1);



		data = VIDTCON0_VBPD(var->upper_margin - 1) |

		       VIDTCON0_VFPD(var->lower_margin - 1) |

		       VIDTCON0_VSPW(var->vsync_len - 1);
@@ -760,32 +787,6 @@ static int s3c_fb_setcolreg(unsigned regno, 
	return 0;

}



/**

 * s3c_fb_enable() - Set the state of the main LCD output

 * @sfb: The main framebuffer state.

 * @enable: The state to set.

 */

static void s3c_fb_enable(struct s3c_fb *sfb, int enable)

{

	u32 vidcon0 = readl(sfb->regs + VIDCON0);



	if (enable)

		vidcon0 |= VIDCON0_ENVID | VIDCON0_ENVID_F;

	else {

		/* see the note in the framebuffer datasheet about

		 * why you cannot take both of these bits down at the

		 * same time. */



		if (!(vidcon0 & VIDCON0_ENVID))

			return;



		vidcon0 |= VIDCON0_ENVID;

		vidcon0 &= ~VIDCON0_ENVID_F;

	}



	writel(vidcon0, sfb->regs + VIDCON0);

}



/**

 * s3c_fb_blank() - blank or unblank the given window

 * @blank_mode: The blank state from FB_BLANK_*

CRA Git | Maintained and supported by SUSTech CRA and CCSE