Commit a2ae6da0 authored Mar 07, 2019 by Arnd Bergmann Committed by David S. Miller Mar 07, 2019

peak_usb: fix clang build warning

Clang points out undefined behavior when building the pcan_usb_pro driver:

drivers/net/can/usb/peak_usb/pcan_usb_pro.c:136:15: error: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]

Changing the function prototype to avoid argument promotion in the
varargs call avoids the warning, and should make this well-defined.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ae9819e3

drivers/net/can/usb/peak_usb/pcan_usb_pro.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -127,7 +127,7 @@ static u8 pcan_msg_init_empty(struct pcan_usb_pro_msg pm,
		/*
		* add one record to a message being built
		*/
		static int pcan_msg_add_rec(struct pcan_usb_pro_msg *pm, u8 id, ...)
		static int pcan_msg_add_rec(struct pcan_usb_pro_msg *pm, int id, ...)
		{
		int len, i;
		u8 *pc;

Admin message