Commit a29be918 authored by Lucas Stach's avatar Lucas Stach Committed by Stephen Boyd
Browse files

clk: imx6q: optionally get CCM inputs via standard clock handles 



When specifying external clock inputs to the CCM the current code
requires the clocks to be in a "clocks" child node of the DT root.
This is not really conformant with DT best practices.

To avoid the need to deviate from those best practices, allow the
clock inputs to be specified via standard clock handles. This is
in line with how drivers of the later CCM driver revisions on
newer i.MX SoCs handle this.

As we can't retroactively change the DT binding, allow this as an
option with a fallback to the old way of how this has been handled.

Signed-off-by: default avatarLucas Stach <l.stach@pengutronix.de>
Acked-by: default avatarRob Herring <robh@kernel.org>
Reviewed-by: default avatarDong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent f7542d81

Documentation/devicetree/bindings/clock/imx6q-clock.txt

+3 −0
Original line number Diff line number Diff line
@@ -13,6 +13,9 @@ Optional properties: 
  management IC (PMIC) triggered via PMIC_STBY_REQ signal.

  Boards that are designed to initiate poweroff on PMIC_ON_REQ signal should

  be using "syscon-poweroff" driver instead.

- clocks: list of clock specifiers, must contain an entry for each entry

          in clock-names

- clock-names: valid names are "osc", "ckil", "ckih1", "anaclk1" and "anaclk2"



The clock consumer should specify the desired clock by having the clock

ID in its "clocks" phandle cell.  See include/dt-bindings/clock/imx6qdl-clock.h

drivers/clk/imx/clk-imx6q.c

+17 −5
Original line number Diff line number Diff line
@@ -414,11 +414,23 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node) 
	int ret;



	clk[IMX6QDL_CLK_DUMMY] = imx_clk_fixed("dummy", 0);

	clk[IMX6QDL_CLK_CKIL] = of_clk_get_by_name(ccm_node, "ckil");

	if (IS_ERR(clk[IMX6QDL_CLK_CKIL]))

		clk[IMX6QDL_CLK_CKIL] = imx_obtain_fixed_clock("ckil", 0);

	clk[IMX6QDL_CLK_CKIH] = of_clk_get_by_name(ccm_node, "ckih1");

	if (IS_ERR(clk[IMX6QDL_CLK_CKIH]))

		clk[IMX6QDL_CLK_CKIH] = imx_obtain_fixed_clock("ckih1", 0);

	clk[IMX6QDL_CLK_OSC] = of_clk_get_by_name(ccm_node, "osc");

	if (IS_ERR(clk[IMX6QDL_CLK_OSC]))

		clk[IMX6QDL_CLK_OSC] = imx_obtain_fixed_clock("osc", 0);



	/* Clock source from external clock via CLK1/2 PADs */

	clk[IMX6QDL_CLK_ANACLK1] = of_clk_get_by_name(ccm_node, "anaclk1");

	if (IS_ERR(clk[IMX6QDL_CLK_ANACLK1]))

		clk[IMX6QDL_CLK_ANACLK1] = imx_obtain_fixed_clock("anaclk1", 0);



	clk[IMX6QDL_CLK_ANACLK2] = of_clk_get_by_name(ccm_node, "anaclk2");

	if (IS_ERR(clk[IMX6QDL_CLK_ANACLK2]))

		clk[IMX6QDL_CLK_ANACLK2] = imx_obtain_fixed_clock("anaclk2", 0);



	np = of_find_compatible_node(NULL, NULL, "fsl,imx6q-anatop");

CRA Git | Maintained and supported by SUSTech CRA and CCSE