Commit a27beb58 authored Mar 17, 2019 by Wolfram Sang Committed by Lorenzo Pieralisi Apr 04, 2019

PCI: rcar: Do not shadow the 'irq' variable



The sparse tool rightfully detects:
drivers/pci/controller/pcie-rcar.c:741:30: warning: symbol 'irq' shadows an earlier one

Fix it now to avoid future surprises and for good coding style.

No functional change intended.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[lorenzo.pieralisi@arm.com: commit log refactoring]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

parent f0d14edd

drivers/pci/controller/pcie-rcar.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -738,15 +738,15 @@ static irqreturn_t rcar_pcie_msi_irq(int irq, void *data)

		while (reg) {
		unsigned int index = find_first_bit(&reg, 32);
		unsigned int irq;
		unsigned int msi_irq;

		/* clear the interrupt */
		rcar_pci_write_reg(pcie, 1 << index, PCIEMSIFR);

		irq = irq_find_mapping(msi->domain, index);
		if (irq) {
		msi_irq = irq_find_mapping(msi->domain, index);
		if (msi_irq) {
		if (test_bit(index, msi->used))
		generic_handle_irq(irq);
		generic_handle_irq(msi_irq);
		else
		dev_info(dev, "unhandled MSI\n");
		} else {

Admin message