Commit a262555b authored Mar 10, 2019 by Andrey Smirnov Committed by Bartosz Golaszewski Mar 18, 2019

gpio: vf610: Simplify vf610_gpio_set()



The only difference between two codepaths is register offset
used. Simplify the code a bit by replacing explicit calls with a
single call with a variable offset. No functional change intended.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: linux-gpio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-imx@nxp.com
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

parent 338aa107

drivers/gpio/gpio-vf610.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -102,11 +102,9 @@ static void vf610_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
		{
		struct vf610_gpio_port *port = gpiochip_get_data(gc);
		unsigned long mask = BIT(gpio);
		unsigned long offset = val ? GPIO_PSOR : GPIO_PCOR;

		if (val)
		vf610_gpio_writel(mask, port->gpio_base + GPIO_PSOR);
		else
		vf610_gpio_writel(mask, port->gpio_base + GPIO_PCOR);
		vf610_gpio_writel(mask, port->gpio_base + offset);
		}

		static int vf610_gpio_direction_input(struct gpio_chip *chip, unsigned gpio)

Admin message