i2c: i2c-bfin-twi: Break dead waiting loop if i2c device misbehaves. (a25733d6) · Commits · 戴 / test

Some fault i2c device may hold the sda/scl line and cause i2c driver wait in the BUS busy loop. The I2C framework already retry the transfer loop before timeout. Return -EAGAIN instead of pull BUSBUSY in the other loop. Signed-off-by:

Sonic Zhang <sonic.zhang@analog.com> Signed-off-by:

Wolfram Sang <w.sang@pengutronix.de>

drivers/i2c/busses/i2c-bfin-twi.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -307,8 +307,8 @@ static int bfin_twi_do_master_xfer(struct i2c_adapter *adap,
		if (!(read_CONTROL(iface) & TWI_ENA))
		return -ENXIO;

		while (read_MASTER_STAT(iface) & BUSBUSY)
		yield();
		if (read_MASTER_STAT(iface) & BUSBUSY)
		return -EAGAIN;

		iface->pmsg = msgs;
		iface->msg_num = num;
		@@ -407,8 +407,8 @@ int bfin_twi_do_smbus_xfer(struct i2c_adapter *adap, u16 addr,
		if (!(read_CONTROL(iface) & TWI_ENA))
		return -ENXIO;

		while (read_MASTER_STAT(iface) & BUSBUSY)
		yield();
		if (read_MASTER_STAT(iface) & BUSBUSY)
		return -EAGAIN;

		iface->writeNum = 0;
		iface->readNum = 0;

Admin message