Commit a251fb90 authored May 06, 2019 by Saar Amar Committed by Paolo Bonzini Jun 20, 2019

KVM: x86: Fix apic dangling pointer in vcpu



The function kvm_create_lapic() attempts to allocate the apic structure
and sets a pointer to it in the virtual processor structure. However, if
get_zeroed_page() failed, the function frees the apic chunk, but forgets
to set the pointer in the vcpu to NULL. It's not a security issue since
there isn't a use of that pointer if kvm_create_lapic() returns error,
but it's more accurate that way.

Signed-off-by: Saar Amar <saaramar@microsoft.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent 4d763b16

arch/x86/kvm/lapic.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2339,6 +2339,7 @@ int kvm_create_lapic(struct kvm_vcpu *vcpu, int timer_advance_ns)
		return 0;
		nomem_free_apic:
		kfree(apic);
		vcpu->arch.apic = NULL;
		nomem:
		return -ENOMEM;
		}

Admin message