Commit a21466cc authored by Dmitry Torokhov's avatar Dmitry Torokhov
Browse files

Input: fix potential overflows in driver/input/touchscreen 



Change all sprintfs into snprintfs to make sure we won't stomp on
data adjacent to our buffers.

Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
parent 10ca4c0a

drivers/input/touchscreen/gunze.c

+1 −1
Original line number Diff line number Diff line
@@ -129,7 +129,7 @@ static int gunze_connect(struct serio *serio, struct serio_driver *drv) 


	gunze->serio = serio;

	gunze->dev = input_dev;

	sprintf(gunze->phys, "%s/input0", serio->phys);

	snprintf(gunze->phys, sizeof(serio->phys), "%s/input0", serio->phys);



	input_dev->private = gunze;

	input_dev->name = "Gunze AHL-51S TouchScreen";

drivers/input/touchscreen/h3600_ts_input.c

+1 −1
Original line number Diff line number Diff line
@@ -363,7 +363,7 @@ static int h3600ts_connect(struct serio *serio, struct serio_driver *drv) 


	ts->serio = serio;

	ts->dev = input_dev;

	sprintf(ts->phys, "%s/input0", serio->phys);

	snprintf(ts->phys, sizeof(ts->phys), "%s/input0", serio->phys);



	input_dev->name = "H3600 TouchScreen";

	input_dev->phys = ts->phys;

drivers/input/touchscreen/mtouch.c

+1 −1
Original line number Diff line number Diff line
@@ -143,7 +143,7 @@ static int mtouch_connect(struct serio *serio, struct serio_driver *drv) 


	mtouch->serio = serio;

	mtouch->dev = input_dev;

	sprintf(mtouch->phys, "%s/input0", serio->phys);

	snprintf(mtouch->phys, sizeof(mtouch->phys), "%s/input0", serio->phys);



	input_dev->private = mtouch;

	input_dev->name = "MicroTouch Serial TouchScreen";

CRA Git | Maintained and supported by SUSTech CRA and CCSE