Commit a20961cc authored Jul 29, 2019 by Gustavo A. R. Silva Committed by David S. Miller Jul 29, 2019

net: smc911x: Mark expected switch fall-through



Mark switch cases where we are expecting to fall through.

This patch fixes the following warning (Building: arm):

drivers/net/ethernet/smsc/smc911x.c: In function ‘smc911x_phy_detect’:
drivers/net/ethernet/smsc/smc911x.c:677:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
    if (cfg & HW_CFG_EXT_PHY_DET_) {
       ^
drivers/net/ethernet/smsc/smc911x.c:715:3: note: here
   default:
   ^~~~~~~

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7bd6ba4e

drivers/net/ethernet/smsc/smc911x.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -712,6 +712,7 @@ static void smc911x_phy_detect(struct net_device *dev)
		/* Found an external PHY */
		break;
		}
		/* Else, fall through */
		default:
		/* Internal media only */
		SMC_GET_PHY_ID1(lp, 1, id1);

Admin message