Commit a208ca98 authored Sep 24, 2015 by Bjorn Andersson Committed by Andy Gross Oct 14, 2015

soc: qcom: smd: Reject send of too big packets



Attempting to find room for a packet that's bigger than the fifo will
never succeed and the calling process will be sleeping forever in the
loop, waiting for enough room. So fail early instead.

Reported-by: Courtney Cavin <courtney.cavin@sonymobile.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Reviewed-by: Andy Gross <agross@codeaurora.org>
Signed-off-by: Andy Gross <agross@codeaurora.org>

parent 24f60e37

drivers/soc/qcom/smd.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -723,6 +723,10 @@ int qcom_smd_send(struct qcom_smd_channel channel, const void data, int len)
		if (channel->info_word && len % 4)
		return -EINVAL;

		/* Reject packets that are too big */
		if (tlen >= channel->fifo_size)
		return -EINVAL;

		ret = mutex_lock_interruptible(&channel->tx_lock);
		if (ret)
		return ret;

Admin message