Commit a2036a1e authored Aug 23, 2018 by Arnd Bergmann Committed by Linus Torvalds Aug 23, 2018

fs/proc/vmcore.c: hide vmcoredd_mmap_dumps() for nommu builds

Without CONFIG_MMU, we get a build warning:

  fs/proc/vmcore.c:228:12: error: 'vmcoredd_mmap_dumps' defined but not used [-Werror=unused-function]
   static int vmcoredd_mmap_dumps(struct vm_area_struct *vma, unsigned long dst,

The function is only referenced from an #ifdef'ed caller, so
this uses the same #ifdef around it.

Link: http://lkml.kernel.org/r/20180525213526.2117790-1-arnd@arndb.de


Fixes: 7efe48df ("vmcore: append device dumps to vmcore as elf notes")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Ganesh Goudar <ganeshgr@chelsio.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 3cc97bea

fs/proc/vmcore.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -225,6 +225,7 @@ out_unlock:
		return ret;
		}

		#ifdef CONFIG_MMU
		static int vmcoredd_mmap_dumps(struct vm_area_struct *vma, unsigned long dst,
		u64 start, size_t size)
		{
		@@ -259,6 +260,7 @@ out_unlock:
		mutex_unlock(&vmcoredd_mutex);
		return ret;
		}
		#endif /* CONFIG_MMU */
		#endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */

		/* Read from the ELF header and then the crash dump. On error, negative value is

Admin message