Commit a1ef8566 authored Jun 01, 2020 by Matthew Wilcox (Oracle) Committed by Linus Torvalds Jun 02, 2020

mm: ignore return value of ->readpages



We used to assign the return value to a variable, which we then ignored.
Remove the pretence of caring.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: William Kucharski <william.kucharski@oracle.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Chao Yu <yuchao0@huawei.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Darrick J. Wong <darrick.wong@oracle.com>
Cc: Eric Biggers <ebiggers@google.com>
Cc: Gao Xiang <gaoxiang25@huawei.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Zi Yan <ziy@nvidia.com>
Cc: Miklos Szeredi <mszeredi@redhat.com>
Link: http://lkml.kernel.org/r/20200414150233.24495-4-willy@infradead.org


Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 9a42823a

mm/readahead.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -113,17 +113,16 @@ int read_cache_pages(struct address_space mapping, struct list_head pages,

		EXPORT_SYMBOL(read_cache_pages);

		static int read_pages(struct address_space mapping, struct file filp,
		static void read_pages(struct address_space mapping, struct file filp,
		struct list_head *pages, unsigned int nr_pages, gfp_t gfp)
		{
		struct blk_plug plug;
		unsigned page_idx;
		int ret;

		blk_start_plug(&plug);

		if (mapping->a_ops->readpages) {
		ret = mapping->a_ops->readpages(filp, mapping, pages, nr_pages);
		mapping->a_ops->readpages(filp, mapping, pages, nr_pages);
		/* Clean up the remaining pages */
		put_pages_list(pages);
		goto out;
		@@ -136,12 +135,9 @@ static int read_pages(struct address_space mapping, struct file filp,
		mapping->a_ops->readpage(filp, page);
		put_page(page);
		}
		ret = 0;

		out:
		blk_finish_plug(&plug);

		return ret;
		}

		/*

Admin message