Commit a1ef7bd9 authored by Kurt Van Dijck's avatar Kurt Van Dijck Committed by Marc Kleine-Budde
Browse files

can: rename LED trigger name on netdev renames 



The LED trigger name for CAN devices is based on the initial
CAN device name, but does never change. The LED trigger name
is not guaranteed to be unique in case of hotplugging CAN devices.

This patch tries to address this problem by modifying the
LED trigger name according to the CAN device name when
the latter changes.

v1 - Kurt Van Dijck
v2 - Fabio Baltieri
- remove rename blocking if trigger is bound
- use led-subsystem function for the actual rename (still WiP)
- call init/exit functions from dev.c
v3 - Kurt Van Dijck
- safe operation for non-candev based devices (vcan, slcan)
	based on earlier patch
v4 - Kurt Van Dijck
- trivial patch mistakes fixed

Signed-off-by: default avatarKurt Van Dijck <kurt.van.dijck@eia.be>
Signed-off-by: default avatarFabio Baltieri <fabio.baltieri@gmail.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent bf03a537

drivers/net/can/dev.c

+5 −0
Original line number Diff line number Diff line
@@ -25,6 +25,7 @@ 
#include <linux/can.h>

#include <linux/can/dev.h>

#include <linux/can/netlink.h>

#include <linux/can/led.h>

#include <net/rtnetlink.h>



#define MOD_DESC "CAN device driver interface"
@@ -811,6 +812,8 @@ static __init int can_dev_init(void) 
{

	int err;



	can_led_notifier_init();



	err = rtnl_link_register(&can_link_ops);

	if (!err)

		printk(KERN_INFO MOD_DESC "\n");
@@ -822,6 +825,8 @@ module_init(can_dev_init); 
static __exit void can_dev_exit(void)

{

	rtnl_link_unregister(&can_link_ops);



	can_led_notifier_exit();

}

module_exit(can_dev_exit);

drivers/net/can/led.c

+38 −0
Original line number Diff line number Diff line 
/*

 * Copyright 2012, Fabio Baltieri <fabio.baltieri@gmail.com>

 * Copyright 2012, Kurt Van Dijck <kurt.van.dijck@eia.be>

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 as
@@ -84,3 +85,40 @@ void devm_can_led_init(struct net_device *netdev) 
	devres_add(&netdev->dev, res);

}

EXPORT_SYMBOL_GPL(devm_can_led_init);



/* NETDEV rename notifier to rename the associated led triggers too */

static int can_led_notifier(struct notifier_block *nb, unsigned long msg,

			void *data)

{

	struct net_device *netdev = data;

	struct can_priv *priv = safe_candev_priv(netdev);

	char name[CAN_LED_NAME_SZ];



	if (!priv)

		return NOTIFY_DONE;



	if (msg == NETDEV_CHANGENAME) {

		snprintf(name, sizeof(name), "%s-tx", netdev->name);

		led_trigger_rename_static(name, priv->tx_led_trig);



		snprintf(name, sizeof(name), "%s-rx", netdev->name);

		led_trigger_rename_static(name, priv->rx_led_trig);

	}



	return NOTIFY_DONE;

}



/* notifier block for netdevice event */

static struct notifier_block can_netdev_notifier __read_mostly = {

	.notifier_call = can_led_notifier,

};



int __init can_led_notifier_init(void)

{

	return register_netdevice_notifier(&can_netdev_notifier);

}



void __exit can_led_notifier_exit(void)

{

	unregister_netdevice_notifier(&can_netdev_notifier);

}

include/linux/can/led.h

+9 −0
Original line number Diff line number Diff line
@@ -26,6 +26,8 @@ enum can_led_event { 


void can_led_event(struct net_device *netdev, enum can_led_event event);

void devm_can_led_init(struct net_device *netdev);

int __init can_led_notifier_init(void);

void __exit can_led_notifier_exit(void);



#else
@@ -36,6 +38,13 @@ static inline void can_led_event(struct net_device *netdev, 
static inline void devm_can_led_init(struct net_device *netdev)

{

}

static inline int can_led_notifier_init(void)

{

	return 0;

}

static inline void can_led_notifier_exit(void)

{

}



#endif

CRA Git | Maintained and supported by SUSTech CRA and CCSE