Commit a1cd4e43 authored Jul 09, 2019 by Arnd Bergmann Committed by David S. Miller Jul 09, 2019

net: dsa: vsc73xx: fix NET_DSA and OF dependencies



The restructuring of the driver got the dependencies wrong: without
CONFIG_NET_DSA we get this build failure:

WARNING: unmet direct dependencies detected for NET_DSA_VITESSE_VSC73XX
  Depends on [n]: NETDEVICES [=y] && HAVE_NET_DSA [=y] && OF [=y] && NET_DSA [=n]
  Selected by [m]:
  - NET_DSA_VITESSE_VSC73XX_PLATFORM [=m] && NETDEVICES [=y] && HAVE_NET_DSA [=y] && HAS_IOMEM [=y]

ERROR: "dsa_unregister_switch" [drivers/net/dsa/vitesse-vsc73xx-core.ko] undefined!
ERROR: "dsa_switch_alloc" [drivers/net/dsa/vitesse-vsc73xx-core.ko] undefined!
ERROR: "dsa_register_switch" [drivers/net/dsa/vitesse-vsc73xx-core.ko] undefined!

Add the appropriate dependencies.

Fixes: 95711cd5 ("net: dsa: vsc73xx: Split vsc73xx driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0488e272

drivers/net/dsa/Kconfig

+4 −0

Original line number	Diff line number	Diff line
		@@ -111,6 +111,8 @@ config NET_DSA_VITESSE_VSC73XX

		config NET_DSA_VITESSE_VSC73XX_SPI
		tristate "Vitesse VSC7385/7388/7395/7398 SPI mode support"
		depends on OF
		depends on NET_DSA
		depends on SPI
		select NET_DSA_VITESSE_VSC73XX
		---help---
		@@ -119,6 +121,8 @@ config NET_DSA_VITESSE_VSC73XX_SPI

		config NET_DSA_VITESSE_VSC73XX_PLATFORM
		tristate "Vitesse VSC7385/7388/7395/7398 Platform mode support"
		depends on OF
		depends on NET_DSA
		depends on HAS_IOMEM
		select NET_DSA_VITESSE_VSC73XX
		---help---

Admin message