mfd: lm3533: Simplify function return logic (a1c16d71) · Commits · 戴 / test

The invoked functions already return zero on success or a negative errno code so there is no need to open code the logic in the caller. Signed-off-by:

Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by:

Lee Jones <lee.jones@linaro.org>

drivers/mfd/lm3533-core.c

+2 −10

Original line number	Diff line number	Diff line
		@@ -472,11 +472,7 @@ static int lm3533_device_setup(struct lm3533 *lm3533,
		if (ret)
		return ret;

		ret = lm3533_set_boost_ovp(lm3533, pdata->boost_ovp);
		if (ret)
		return ret;

		return 0;
		return lm3533_set_boost_ovp(lm3533, pdata->boost_ovp);
		}

		static int lm3533_device_init(struct lm3533 *lm3533)
		@@ -613,11 +609,7 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
		lm3533->dev = &i2c->dev;
		lm3533->irq = i2c->irq;

		ret = lm3533_device_init(lm3533);
		if (ret)
		return ret;

		return 0;
		return lm3533_device_init(lm3533);
		}

		static int lm3533_i2c_remove(struct i2c_client *i2c)

Admin message