Commit a1bb46c3 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

ACPI: processor: Add QoS requests for all CPUs 



The _PPC change notifications from the platform firmware are per-CPU,
so acpi_processor_ppc_init() needs to add a frequency QoS request
for each CPU covered by a cpufreq policy to take all of them into
account.

Even though ACPI thermal control of CPUs sets frequency limits
per processor package, it also needs a frequency QoS request for each
CPU in a cpufreq policy in case some of them are taken offline and
the frequency limit needs to be set through the remaining online
ones (this is slightly excessive, because all CPUs covered by one
cpufreq policy will set the same frequency limit through their QoS
requests, but it is not incorrect).

Modify the code in accordance with the above observations.

Fixes: d15ce412 ("ACPI: cpufreq: Switch to QoS requests instead of cpufreq notifier")
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent 6941051d

drivers/acpi/processor_perflib.c

+21 −13
Original line number Diff line number Diff line
@@ -159,27 +159,35 @@ void acpi_processor_ignore_ppc_init(void) 


void acpi_processor_ppc_init(struct cpufreq_policy *policy)

{

	int cpu = policy->cpu;

	unsigned int cpu;



	for_each_cpu(cpu, policy->related_cpus) {

		struct acpi_processor *pr = per_cpu(processors, cpu);

		int ret;



		if (!pr)

		return;

			continue;



	ret = freq_qos_add_request(&policy->constraints, &pr->perflib_req,

		ret = freq_qos_add_request(&policy->constraints,

					   &pr->perflib_req,

					   FREQ_QOS_MAX, INT_MAX);

		if (ret < 0)

		pr_err("Failed to add freq constraint for CPU%d (%d)\n", cpu,

		       ret);

			pr_err("Failed to add freq constraint for CPU%d (%d)\n",

			       cpu, ret);

	}

}



void acpi_processor_ppc_exit(struct cpufreq_policy *policy)

{

	struct acpi_processor *pr = per_cpu(processors, policy->cpu);

	unsigned int cpu;



	for_each_cpu(cpu, policy->related_cpus) {

		struct acpi_processor *pr = per_cpu(processors, cpu);



		if (pr)

			freq_qos_remove_request(&pr->perflib_req);

	}

}



static int acpi_processor_get_performance_control(struct acpi_processor *pr)

{

drivers/acpi/processor_thermal.c

+21 −13
Original line number Diff line number Diff line
@@ -127,27 +127,35 @@ static int cpufreq_set_cur_state(unsigned int cpu, int state) 


void acpi_thermal_cpufreq_init(struct cpufreq_policy *policy)

{

	int cpu = policy->cpu;

	unsigned int cpu;



	for_each_cpu(cpu, policy->related_cpus) {

		struct acpi_processor *pr = per_cpu(processors, cpu);

		int ret;



		if (!pr)

		return;

			continue;



	ret = freq_qos_add_request(&policy->constraints, &pr->thermal_req,

		ret = freq_qos_add_request(&policy->constraints,

					   &pr->thermal_req,

					   FREQ_QOS_MAX, INT_MAX);

		if (ret < 0)

		pr_err("Failed to add freq constraint for CPU%d (%d)\n", cpu,

		       ret);

			pr_err("Failed to add freq constraint for CPU%d (%d)\n",

			       cpu, ret);

	}

}



void acpi_thermal_cpufreq_exit(struct cpufreq_policy *policy)

{

	unsigned int cpu;



	for_each_cpu(cpu, policy->related_cpus) {

		struct acpi_processor *pr = per_cpu(processors, policy->cpu);



		if (pr)

			freq_qos_remove_request(&pr->thermal_req);

	}

}

#else				/* ! CONFIG_CPU_FREQ */

static int cpufreq_get_max_state(unsigned int cpu)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE