Commit a1a66393 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

ACPI / PM: Drop run_wake from struct acpi_device_wakeup_flags 



The run_wake flag in struct acpi_device_wakeup_flags stores the
information on whether or not the device can generate wakeup
signals at run time, but in ACPI that really is equivalent to
being able to generate wakeup signals at all.

In fact, run_wake will always be set after successful executeion of
acpi_setup_gpe_for_wake(), but if that fails, the device will not be
able to use a wakeup GPE at all, so it won't be able to wake up the
systems from sleep states too.  Hence, run_wake actually means that
the device is capable of triggering wakeup and so it is equivalent
to the valid flag.

For this reason, drop run_wake from struct acpi_device_wakeup_flags
and make sure that the valid flag is only set if
acpi_setup_gpe_for_wake() has been successful.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 8110dd28

drivers/acpi/pci_root.c

+1 −1
Original line number Diff line number Diff line
@@ -608,7 +608,7 @@ static int acpi_pci_root_add(struct acpi_device *device, 
		pcie_no_aspm();



	pci_acpi_add_bus_pm_notifier(device);

	if (device->wakeup.flags.run_wake)

	if (device->wakeup.flags.valid)

		device_set_run_wake(root->bus->bridge, true);



	if (hotadd) {

drivers/acpi/proc.c

+2 −2
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ acpi_system_wakeup_device_seq_show(struct seq_file *seq, void *offset) 


		if (!dev->physical_node_count) {

			seq_printf(seq, "%c%-8s\n",

				dev->wakeup.flags.run_wake ? '*' : ' ',

				dev->wakeup.flags.valid ? '*' : ' ',

				device_may_wakeup(&dev->dev) ?

					"enabled" : "disabled");

		} else {
@@ -58,7 +58,7 @@ acpi_system_wakeup_device_seq_show(struct seq_file *seq, void *offset) 
					seq_printf(seq, "\t\t");



				seq_printf(seq, "%c%-8s  %s:%s\n",

					dev->wakeup.flags.run_wake ? '*' : ' ',

					dev->wakeup.flags.valid ? '*' : ' ',

					(device_may_wakeup(&dev->dev) ||

					device_may_wakeup(ldev)) ?

					"enabled" : "disabled",

drivers/acpi/scan.c

+8 −15
Original line number Diff line number Diff line
@@ -835,7 +835,7 @@ static int acpi_bus_extract_wakeup_device_power_package(acpi_handle handle, 
	return err;

}



static void acpi_wakeup_gpe_init(struct acpi_device *device)

static bool acpi_wakeup_gpe_init(struct acpi_device *device)

{

	static const struct acpi_device_id button_device_ids[] = {

		{"PNP0C0C", 0},
@@ -845,13 +845,11 @@ static void acpi_wakeup_gpe_init(struct acpi_device *device) 
	};

	struct acpi_device_wakeup *wakeup = &device->wakeup;

	acpi_status status;

	acpi_event_status event_status;



	wakeup->flags.notifier_present = 0;



	/* Power button, Lid switch always enable wakeup */

	if (!acpi_match_device_ids(device, button_device_ids)) {

		wakeup->flags.run_wake = 1;

		if (!acpi_match_device_ids(device, &button_device_ids[1])) {

			/* Do not use Lid/sleep button for S5 wakeup */

			if (wakeup->sleep_state == ACPI_STATE_S5)
@@ -859,17 +857,12 @@ static void acpi_wakeup_gpe_init(struct acpi_device *device) 
		}

		acpi_mark_gpe_for_wake(wakeup->gpe_device, wakeup->gpe_number);

		device_set_wakeup_capable(&device->dev, true);

		return;

		return true;

	}



	acpi_setup_gpe_for_wake(device->handle, wakeup->gpe_device,

	status = acpi_setup_gpe_for_wake(device->handle, wakeup->gpe_device,

					 wakeup->gpe_number);

	status = acpi_get_gpe_status(wakeup->gpe_device, wakeup->gpe_number,

				     &event_status);

	if (ACPI_FAILURE(status))

		return;



	wakeup->flags.run_wake = !!(event_status & ACPI_EVENT_FLAG_HAS_HANDLER);

	return ACPI_SUCCESS(status);

}



static void acpi_bus_get_wakeup_device_flags(struct acpi_device *device)
@@ -887,10 +880,10 @@ static void acpi_bus_get_wakeup_device_flags(struct acpi_device *device) 
		return;

	}



	device->wakeup.flags.valid = 1;

	device->wakeup.flags.valid = acpi_wakeup_gpe_init(device);

	device->wakeup.prepare_count = 0;

	acpi_wakeup_gpe_init(device);

	/* Call _PSW/_DSW object to disable its ability to wake the sleeping

	/*

	 * Call _PSW/_DSW object to disable its ability to wake the sleeping

	 * system for the ACPI device with the _PRW object.

	 * The _PSW object is depreciated in ACPI 3.0 and is replaced by _DSW.

	 * So it is necessary to call _DSW object first. Only when it is not

drivers/pci/pci-acpi.c

+1 −2
Original line number Diff line number Diff line
@@ -777,9 +777,8 @@ static void pci_acpi_setup(struct device *dev) 
		return;



	device_set_wakeup_capable(dev, true);

	acpi_pci_sleep_wake(pci_dev, false);

	if (adev->wakeup.flags.run_wake)

	device_set_run_wake(dev, true);

	acpi_pci_sleep_wake(pci_dev, false);

}



static void pci_acpi_cleanup(struct device *dev)

include/acpi/acpi_bus.h

+0 −1
Original line number Diff line number Diff line
@@ -314,7 +314,6 @@ struct acpi_device_perf { 
/* Wakeup Management */

struct acpi_device_wakeup_flags {

	u8 valid:1;		/* Can successfully enable wakeup? */

	u8 run_wake:1;		/* Run-Wake GPE devices */

	u8 notifier_present:1;  /* Wake-up notify handler has been installed */

	u8 enabled:1;		/* Enabled for wakeup */

};

CRA Git | Maintained and supported by SUSTech CRA and CCSE