Commit a1989b33 authored Feb 26, 2014 by Hannes Reinecke Committed by Mike Snitzer Feb 26, 2014

dm mpath: fix stalls when handling invalid ioctls



An invalid ioctl will never be valid, irrespective of whether multipath
has active paths or not.  So for invalid ioctls we do not have to wait
for multipath to activate any paths, but can rather return an error
code immediately.  This fix resolves numerous instances of:

 udevd[]: worker [] unexpectedly returned with status 0x0100

that have been seen during testing.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org

parent 1acacc07

drivers/md/dm-mpath.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -1626,8 +1626,11 @@ static int multipath_ioctl(struct dm_target *ti, unsigned int cmd,
		/*
		* Only pass ioctls through if the device sizes match exactly.
		*/
		if (!r && ti->len != i_size_read(bdev->bd_inode) >> SECTOR_SHIFT)
		r = scsi_verify_blk_ioctl(NULL, cmd);
		if (!bdev \|\| ti->len != i_size_read(bdev->bd_inode) >> SECTOR_SHIFT) {
		int err = scsi_verify_blk_ioctl(NULL, cmd);
		if (err)
		r = err;
		}

		if (r == -ENOTCONN && !fatal_signal_pending(current))
		queue_work(kmultipathd, &m->process_queued_ios);

Admin message