Commit a1794de8 authored Aug 12, 2019 by Xin Long Committed by Jakub Kicinski Aug 13, 2019

sctp: fix the transport error_count check



As the annotation says in sctp_do_8_2_transport_strike():

  "If the transport error count is greater than the pf_retrans
   threshold, and less than pathmaxrtx ..."

It should be transport->error_count checked with pathmaxrxt,
instead of asoc->pf_retrans.

Fixes: 5aa93bcf ("sctp: Implement quick failover draft from tsvwg")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>

parent bb0ce4c1

net/sctp/sm_sideeffect.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -546,7 +546,7 @@ static void sctp_do_8_2_transport_strike(struct sctp_cmd_seq *commands,
		*/
		if (net->sctp.pf_enable &&
		(transport->state == SCTP_ACTIVE) &&
		(asoc->pf_retrans < transport->pathmaxrxt) &&
		(transport->error_count < transport->pathmaxrxt) &&
		(transport->error_count > asoc->pf_retrans)) {

		sctp_assoc_control_transport(asoc, transport,

Admin message