Commit a16e772e authored by Eric Biggers's avatar Eric Biggers Committed by Herbert Xu
Browse files

crypto: poly1305 - remove ->setkey() method 



Since Poly1305 requires a nonce per invocation, the Linux kernel
implementations of Poly1305 don't use the crypto API's keying mechanism
and instead expect the key and nonce as the first 32 bytes of the data.
But ->setkey() is still defined as a stub returning an error code.  This
prevents Poly1305 from being used through AF_ALG and will also break it
completely once we start enforcing that all crypto API users (not just
AF_ALG) call ->setkey() if present.

Fix it by removing crypto_poly1305_setkey(), leaving ->setkey as NULL.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent fa59b92d

arch/x86/crypto/poly1305_glue.c

+0 −1
Original line number Diff line number Diff line
@@ -164,7 +164,6 @@ static struct shash_alg alg = { 
	.init		= poly1305_simd_init,

	.update		= poly1305_simd_update,

	.final		= crypto_poly1305_final,

	.setkey		= crypto_poly1305_setkey,

	.descsize	= sizeof(struct poly1305_simd_desc_ctx),

	.base		= {

		.cra_name		= "poly1305",

crypto/poly1305_generic.c

+5 −12
Original line number Diff line number Diff line
@@ -47,17 +47,6 @@ int crypto_poly1305_init(struct shash_desc *desc) 
}

EXPORT_SYMBOL_GPL(crypto_poly1305_init);



int crypto_poly1305_setkey(struct crypto_shash *tfm,

			   const u8 *key, unsigned int keylen)

{

	/* Poly1305 requires a unique key for each tag, which implies that

	 * we can't set it on the tfm that gets accessed by multiple users

	 * simultaneously. Instead we expect the key as the first 32 bytes in

	 * the update() call. */

	return -ENOTSUPP;

}

EXPORT_SYMBOL_GPL(crypto_poly1305_setkey);



static void poly1305_setrkey(struct poly1305_desc_ctx *dctx, const u8 *key)

{

	/* r &= 0xffffffc0ffffffc0ffffffc0fffffff */
@@ -76,6 +65,11 @@ static void poly1305_setskey(struct poly1305_desc_ctx *dctx, const u8 *key) 
	dctx->s[3] = get_unaligned_le32(key + 12);

}



/*

 * Poly1305 requires a unique key for each tag, which implies that we can't set

 * it on the tfm that gets accessed by multiple users simultaneously. Instead we

 * expect the key as the first 32 bytes in the update() call.

 */

unsigned int crypto_poly1305_setdesckey(struct poly1305_desc_ctx *dctx,

					const u8 *src, unsigned int srclen)

{
@@ -280,7 +274,6 @@ static struct shash_alg poly1305_alg = { 
	.init		= crypto_poly1305_init,

	.update		= crypto_poly1305_update,

	.final		= crypto_poly1305_final,

	.setkey		= crypto_poly1305_setkey,

	.descsize	= sizeof(struct poly1305_desc_ctx),

	.base		= {

		.cra_name		= "poly1305",

include/crypto/poly1305.h

+0 −2
Original line number Diff line number Diff line
@@ -31,8 +31,6 @@ struct poly1305_desc_ctx { 
};



int crypto_poly1305_init(struct shash_desc *desc);

int crypto_poly1305_setkey(struct crypto_shash *tfm,

			   const u8 *key, unsigned int keylen);

unsigned int crypto_poly1305_setdesckey(struct poly1305_desc_ctx *dctx,

					const u8 *src, unsigned int srclen);

int crypto_poly1305_update(struct shash_desc *desc,

CRA Git | Maintained and supported by SUSTech CRA and CCSE