Commit a16cee10 authored by Wen Congyang's avatar Wen Congyang Committed by Linus Torvalds
Browse files

memory-hotplug: preparation to notify memory block's state at memory hot remove 



remove_memory() is called in two cases:
1. echo offline >/sys/devices/system/memory/memoryXX/state
2. hot remove a memory device

In the 1st case, the memory block's state is changed and the notification
that memory block's state changed is sent to userland after calling
remove_memory().  So user can notice memory block is changed.

But in the 2nd case, the memory block's state is not changed and the
notification is not also sent to userspcae even if calling
remove_memory().  So user cannot notice memory block is changed.

For adding the notification at memory hot remove, the patch just prepare
as follows:
1st case uses offline_pages() for offlining memory.
2nd case uses remove_memory() for offlining memory and changing memory block's
    state and notifing the information.

The patch does not implement notification to remove_memory().

Signed-off-by: default avatarWen Congyang <wency@cn.fujitsu.com>
Signed-off-by: default avatarYasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Jiang Liu <liuj97@gmail.com>
Cc: Len Brown <len.brown@intel.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c2233116

drivers/base/memory.c

+3 −6
Original line number Diff line number Diff line
@@ -248,26 +248,23 @@ static bool pages_correctly_reserved(unsigned long start_pfn, 
static int

memory_block_action(unsigned long phys_index, unsigned long action)

{

	unsigned long start_pfn, start_paddr;

	unsigned long start_pfn;

	unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block;

	struct page *first_page;

	int ret;



	first_page = pfn_to_page(phys_index << PFN_SECTION_SHIFT);

	start_pfn = page_to_pfn(first_page);



	switch (action) {

		case MEM_ONLINE:

			start_pfn = page_to_pfn(first_page);



			if (!pages_correctly_reserved(start_pfn, nr_pages))

				return -EBUSY;



			ret = online_pages(start_pfn, nr_pages);

			break;

		case MEM_OFFLINE:

			start_paddr = page_to_pfn(first_page) << PAGE_SHIFT;

			ret = remove_memory(start_paddr,

					    nr_pages << PAGE_SHIFT);

			ret = offline_pages(start_pfn, nr_pages);

			break;

		default:

			WARN(1, KERN_WARNING "%s(%ld, %ld) unknown action: "

include/linux/memory_hotplug.h

+1 −0
Original line number Diff line number Diff line
@@ -233,6 +233,7 @@ static inline int is_mem_section_removable(unsigned long pfn, 
extern int mem_online_node(int nid);

extern int add_memory(int nid, u64 start, u64 size);

extern int arch_add_memory(int nid, u64 start, u64 size);

extern int offline_pages(unsigned long start_pfn, unsigned long nr_pages);

extern int remove_memory(u64 start, u64 size);

extern int sparse_add_one_section(struct zone *zone, unsigned long start_pfn,

								int nr_pages);

mm/memory_hotplug.c

+11 −2
Original line number Diff line number Diff line
@@ -874,7 +874,7 @@ check_pages_isolated(unsigned long start_pfn, unsigned long end_pfn) 
	return offlined;

}



static int __ref offline_pages(unsigned long start_pfn,

static int __ref __offline_pages(unsigned long start_pfn,

		  unsigned long end_pfn, unsigned long timeout)

{

	unsigned long pfn, nr_pages, expire;
@@ -1007,15 +1007,24 @@ out: 
	return ret;

}



int offline_pages(unsigned long start_pfn, unsigned long nr_pages)

{

	return __offline_pages(start_pfn, start_pfn + nr_pages, 120 * HZ);

}



int remove_memory(u64 start, u64 size)

{

	unsigned long start_pfn, end_pfn;



	start_pfn = PFN_DOWN(start);

	end_pfn = start_pfn + PFN_DOWN(size);

	return offline_pages(start_pfn, end_pfn, 120 * HZ);

	return __offline_pages(start_pfn, end_pfn, 120 * HZ);

}

#else

int offline_pages(unsigned long start_pfn, unsigned long nr_pages)

{

	return -EINVAL;

}

int remove_memory(u64 start, u64 size)

{

	return -EINVAL;

CRA Git | Maintained and supported by SUSTech CRA and CCSE