Commit a1645eef authored Mar 15, 2013 by Colin Ian King Committed by Greg Kroah-Hartman Mar 15, 2013

usb: misc: sisusbvga: Avoid NULL pointer dereference from sisusb



A failed kzalloc() is reported with a dev_err that dereferences the null
sisusb, this will cause a NULL pointer deference error.

Instead, pass dev->dev to the dev_err() rather than &sisusb->sisusb_dev->dev

Smatch analysis:

drivers/usb/misc/sisusbvga/sisusb.c:3087 sisusb_probe() error: potential null
  dereference 'sisusb'.  (kzalloc returns null)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 5b2750d5

drivers/usb/misc/sisusbvga/sisusb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3084,7 +3084,7 @@ static int sisusb_probe(struct usb_interface *intf,

		/* Allocate memory for our private */
		if (!(sisusb = kzalloc(sizeof(*sisusb), GFP_KERNEL))) {
		dev_err(&sisusb->sisusb_dev->dev, "Failed to allocate memory for private data\n");
		dev_err(&dev->dev, "Failed to allocate memory for private data\n");
		return -ENOMEM;
		}
		kref_init(&sisusb->kref);

Admin message