Commit a15bd354 authored by Alexander Graf's avatar Alexander Graf Committed by Avi Kivity
Browse files

KVM: PPC: Add support for explicit HIOR setting 



Until now, we always set HIOR based on the PVR, but this is just wrong.
Instead, we should be setting HIOR explicitly, so user space can decide
what the initial HIOR value is - just like on real hardware.

We keep the old PVR based way around for backwards compatibility, but
once user space uses the SREGS based method, we drop the PVR logic.

Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
parent 77e675ad

arch/powerpc/include/asm/kvm.h

+8 −0
Original line number Diff line number Diff line
@@ -148,6 +148,12 @@ struct kvm_regs { 
#define KVM_SREGS_E_UPDATE_DEC		(1 << 2)

#define KVM_SREGS_E_UPDATE_DBSR		(1 << 3)



/*

 * Book3S special bits to indicate contents in the struct by maintaining

 * backwards compatibility with older structs. If adding a new field,

 * please make sure to add a flag for that new field */

#define KVM_SREGS_S_HIOR		(1 << 0)



/*

 * In KVM_SET_SREGS, reserved/pad fields must be left untouched from a

 * previous KVM_GET_REGS.
@@ -173,6 +179,8 @@ struct kvm_sregs { 
				__u64 ibat[8]; 

				__u64 dbat[8]; 

			} ppc32;

			__u64 flags; /* KVM_SREGS_S_ */

			__u64 hior;

		} s;

		struct {

			union {

arch/powerpc/include/asm/kvm_book3s.h

+2 −0
Original line number Diff line number Diff line
@@ -90,6 +90,8 @@ struct kvmppc_vcpu_book3s { 
#endif

	int context_id[SID_CONTEXTS];



	bool hior_sregs;		/* HIOR is set by SREGS, not PVR */



	struct hlist_head hpte_hash_pte[HPTEG_HASH_NUM_PTE];

	struct hlist_head hpte_hash_pte_long[HPTEG_HASH_NUM_PTE_LONG];

	struct hlist_head hpte_hash_vpte[HPTEG_HASH_NUM_VPTE];

arch/powerpc/kvm/book3s_pr.c

+12 −2
Original line number Diff line number Diff line
@@ -150,12 +150,14 @@ void kvmppc_set_pvr(struct kvm_vcpu *vcpu, u32 pvr) 
#ifdef CONFIG_PPC_BOOK3S_64

	if ((pvr >= 0x330000) && (pvr < 0x70330000)) {

		kvmppc_mmu_book3s_64_init(vcpu);

		if (!to_book3s(vcpu)->hior_sregs)

			to_book3s(vcpu)->hior = 0xfff00000;

		to_book3s(vcpu)->msr_mask = 0xffffffffffffffffULL;

	} else

#endif

	{

		kvmppc_mmu_book3s_32_init(vcpu);

		if (!to_book3s(vcpu)->hior_sregs)

			to_book3s(vcpu)->hior = 0;

		to_book3s(vcpu)->msr_mask = 0xffffffffULL;

	}
@@ -770,6 +772,9 @@ int kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu *vcpu, 
		}

	}



	if (sregs->u.s.flags & KVM_SREGS_S_HIOR)

		sregs->u.s.hior = to_book3s(vcpu)->hior;



	return 0;

}
@@ -806,6 +811,11 @@ int kvm_arch_vcpu_ioctl_set_sregs(struct kvm_vcpu *vcpu, 
	/* Flush the MMU after messing with the segments */

	kvmppc_mmu_pte_flush(vcpu, 0, 0);



	if (sregs->u.s.flags & KVM_SREGS_S_HIOR) {

		to_book3s(vcpu)->hior_sregs = true;

		to_book3s(vcpu)->hior = sregs->u.s.hior;

	}



	return 0;

}

arch/powerpc/kvm/powerpc.c

+1 −0
Original line number Diff line number Diff line
@@ -188,6 +188,7 @@ int kvm_dev_ioctl_check_extension(long ext) 
	case KVM_CAP_PPC_BOOKE_SREGS:

#else

	case KVM_CAP_PPC_SEGSTATE:

	case KVM_CAP_PPC_HIOR:

#endif

	case KVM_CAP_PPC_UNSET_IRQ:

	case KVM_CAP_PPC_IRQ_LEVEL:

include/linux/kvm.h

+1 −0
Original line number Diff line number Diff line
@@ -554,6 +554,7 @@ struct kvm_ppc_pvinfo { 
#define KVM_CAP_PPC_SMT 64

#define KVM_CAP_PPC_RMA	65

#define KVM_CAP_MAX_VCPUS 66       /* returns max vcpus per vm */

#define KVM_CAP_PPC_HIOR 67

#define KVM_CAP_S390_GMAP 71



#ifdef KVM_CAP_IRQ_ROUTING

CRA Git | Maintained and supported by SUSTech CRA and CCSE