net: hns3: Fix for geneve tx checksum bug (a156998f) · Commits · 戴 / test

when skb->encapsulation is 0, skb->ip_summed is CHECKSUM_PARTIAL and it is udp packet, which has a dest port as the IANA assigned. the hardware is expected to do the checksum offload, but the hardware will not do the checksum offload when udp dest port is 6081. This patch fixes it by doing the checksum in software. Reported-by:

Li Bing <libing@winhong.com> Signed-off-by:

Yi Li <yili@winhong.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -21,6 +21,7 @@
		#include <net/pkt_cls.h>
		#include <net/tcp.h>
		#include <net/vxlan.h>
		#include <net/geneve.h>

		#include "hnae3.h"
		#include "hns3_enet.h"
		@@ -780,7 +781,7 @@ static int hns3_get_l4_protocol(struct sk_buff skb, u8 ol4_proto,
		* and it is udp packet, which has a dest port as the IANA assigned.
		* the hardware is expected to do the checksum offload, but the
		* hardware will not do the checksum offload when udp dest port is
		* 4789.
		* 4789 or 6081.
		*/
		static bool hns3_tunnel_csum_bug(struct sk_buff *skb)
		{
		@@ -789,7 +790,8 @@ static bool hns3_tunnel_csum_bug(struct sk_buff *skb)
		l4.hdr = skb_transport_header(skb);

		if (!(!skb->encapsulation &&
		l4.udp->dest == htons(IANA_VXLAN_UDP_PORT)))
		(l4.udp->dest == htons(IANA_VXLAN_UDP_PORT) \|\|
		l4.udp->dest == htons(GENEVE_UDP_PORT))))
		return false;

		skb_checksum_help(skb);

Admin message