Commit a0e928ed authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 

Pull timer updates from Ingo Molnar:
 "This cycle had the following changes:

   - Timer tracing improvements (Anna-Maria Gleixner)

   - Continued tasklet reduction work: remove the hrtimer_tasklet
     (Thomas Gleixner)

   - Fix CPU hotplug remove race in the tick-broadcast mask handling
     code (Thomas Gleixner)

   - Force upper bound for setting CLOCK_REALTIME, to fix ABI
     inconsistencies with handling values that are close to the maximum
     supported and the vagueness of when uptime related wraparound might
     occur. Make the consistent maximum the year 2232 across all
     relevant ABIs and APIs. (Thomas Gleixner)

   - various cleanups and smaller fixes"

* 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  tick: Fix typos in comments
  tick/broadcast: Fix warning about undefined tick_broadcast_oneshot_offline()
  timekeeping: Force upper bound for setting CLOCK_REALTIME
  timer/trace: Improve timer tracing
  timer/trace: Replace deprecated vsprintf pointer extension %pf by %ps
  timer: Move trace point to get proper index
  tick/sched: Update tick_sched struct documentation
  tick: Remove outgoing CPU from broadcast masks
  timekeeping: Consistently use unsigned int for seqcount snapshot
  softirq: Remove tasklet_hrtimer
  xfrm: Replace hrtimer tasklet with softirq hrtimer
  mac80211_hwsim: Replace hrtimer tasklet with softirq hrtimer
parents 5a2bf1ab 13e792a1

drivers/net/wireless/mac80211_hwsim.c

+21 −25
Original line number Diff line number Diff line
@@ -521,7 +521,7 @@ struct mac80211_hwsim_data { 
	unsigned int rx_filter;

	bool started, idle, scanning;

	struct mutex mutex;

	struct tasklet_hrtimer beacon_timer;

	struct hrtimer beacon_timer;

	enum ps_mode {

		PS_DISABLED, PS_ENABLED, PS_AUTO_POLL, PS_MANUAL_POLL

	} ps;
@@ -1460,7 +1460,7 @@ static void mac80211_hwsim_stop(struct ieee80211_hw *hw) 
{

	struct mac80211_hwsim_data *data = hw->priv;

	data->started = false;

	tasklet_hrtimer_cancel(&data->beacon_timer);

	hrtimer_cancel(&data->beacon_timer);

	wiphy_dbg(hw->wiphy, "%s\n", __func__);

}
@@ -1583,14 +1583,12 @@ static enum hrtimer_restart 
mac80211_hwsim_beacon(struct hrtimer *timer)

{

	struct mac80211_hwsim_data *data =

		container_of(timer, struct mac80211_hwsim_data,

			     beacon_timer.timer);

		container_of(timer, struct mac80211_hwsim_data, beacon_timer);

	struct ieee80211_hw *hw = data->hw;

	u64 bcn_int = data->beacon_int;

	ktime_t next_bcn;



	if (!data->started)

		goto out;

		return HRTIMER_NORESTART;



	ieee80211_iterate_active_interfaces_atomic(

		hw, IEEE80211_IFACE_ITER_NORMAL,
@@ -1601,12 +1599,9 @@ mac80211_hwsim_beacon(struct hrtimer *timer) 
		bcn_int -= data->bcn_delta;

		data->bcn_delta = 0;

	}



	next_bcn = ktime_add(hrtimer_get_expires(timer),

			     ns_to_ktime(bcn_int * 1000));

	tasklet_hrtimer_start(&data->beacon_timer, next_bcn, HRTIMER_MODE_ABS);

out:

	return HRTIMER_NORESTART;

	hrtimer_forward(&data->beacon_timer, hrtimer_get_expires(timer),

			ns_to_ktime(bcn_int * NSEC_PER_USEC));

	return HRTIMER_RESTART;

}



static const char * const hwsim_chanwidths[] = {
@@ -1680,15 +1675,15 @@ static int mac80211_hwsim_config(struct ieee80211_hw *hw, u32 changed) 
	mutex_unlock(&data->mutex);



	if (!data->started || !data->beacon_int)

		tasklet_hrtimer_cancel(&data->beacon_timer);

	else if (!hrtimer_is_queued(&data->beacon_timer.timer)) {

		hrtimer_cancel(&data->beacon_timer);

	else if (!hrtimer_is_queued(&data->beacon_timer)) {

		u64 tsf = mac80211_hwsim_get_tsf(hw, NULL);

		u32 bcn_int = data->beacon_int;

		u64 until_tbtt = bcn_int - do_div(tsf, bcn_int);



		tasklet_hrtimer_start(&data->beacon_timer,

				      ns_to_ktime(until_tbtt * 1000),

				      HRTIMER_MODE_REL);

		hrtimer_start(&data->beacon_timer,

			      ns_to_ktime(until_tbtt * NSEC_PER_USEC),

			      HRTIMER_MODE_REL_SOFT);

	}



	return 0;
@@ -1751,7 +1746,7 @@ static void mac80211_hwsim_bss_info_changed(struct ieee80211_hw *hw, 
			  info->enable_beacon, info->beacon_int);

		vp->bcn_en = info->enable_beacon;

		if (data->started &&

		    !hrtimer_is_queued(&data->beacon_timer.timer) &&

		    !hrtimer_is_queued(&data->beacon_timer) &&

		    info->enable_beacon) {

			u64 tsf, until_tbtt;

			u32 bcn_int;
@@ -1759,9 +1754,10 @@ static void mac80211_hwsim_bss_info_changed(struct ieee80211_hw *hw, 
			tsf = mac80211_hwsim_get_tsf(hw, vif);

			bcn_int = data->beacon_int;

			until_tbtt = bcn_int - do_div(tsf, bcn_int);

			tasklet_hrtimer_start(&data->beacon_timer,

					      ns_to_ktime(until_tbtt * 1000),

					      HRTIMER_MODE_REL);



			hrtimer_start(&data->beacon_timer,

				      ns_to_ktime(until_tbtt * NSEC_PER_USEC),

				      HRTIMER_MODE_REL_SOFT);

		} else if (!info->enable_beacon) {

			unsigned int count = 0;

			ieee80211_iterate_active_interfaces_atomic(
@@ -1770,7 +1766,7 @@ static void mac80211_hwsim_bss_info_changed(struct ieee80211_hw *hw, 
			wiphy_dbg(hw->wiphy, "  beaconing vifs remaining: %u",

				  count);

			if (count == 0) {

				tasklet_hrtimer_cancel(&data->beacon_timer);

				hrtimer_cancel(&data->beacon_timer);

				data->beacon_int = 0;

			}

		}
@@ -2933,9 +2929,9 @@ static int mac80211_hwsim_new_radio(struct genl_info *info, 


	wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_CQM_RSSI_LIST);



	tasklet_hrtimer_init(&data->beacon_timer,

			     mac80211_hwsim_beacon,

			     CLOCK_MONOTONIC, HRTIMER_MODE_ABS);

	hrtimer_init(&data->beacon_timer, CLOCK_MONOTONIC,

		     HRTIMER_MODE_ABS_SOFT);

	data->beacon_timer.function = mac80211_hwsim_beacon;



	err = ieee80211_register_hw(hw);

	if (err < 0) {

include/linux/interrupt.h

+0 −25
Original line number Diff line number Diff line
@@ -668,31 +668,6 @@ extern void tasklet_kill_immediate(struct tasklet_struct *t, unsigned int cpu); 
extern void tasklet_init(struct tasklet_struct *t,

			 void (*func)(unsigned long), unsigned long data);



struct tasklet_hrtimer {

	struct hrtimer		timer;

	struct tasklet_struct	tasklet;

	enum hrtimer_restart	(*function)(struct hrtimer *);

};



extern void

tasklet_hrtimer_init(struct tasklet_hrtimer *ttimer,

		     enum hrtimer_restart (*function)(struct hrtimer *),

		     clockid_t which_clock, enum hrtimer_mode mode);



static inline

void tasklet_hrtimer_start(struct tasklet_hrtimer *ttimer, ktime_t time,

			   const enum hrtimer_mode mode)

{

	hrtimer_start(&ttimer->timer, time, mode);

}



static inline

void tasklet_hrtimer_cancel(struct tasklet_hrtimer *ttimer)

{

	hrtimer_cancel(&ttimer->timer);

	tasklet_kill(&ttimer->tasklet);

}



/*

 * Autoprobing for irqs:

 *

include/linux/tick.h

+6 −0
Original line number Diff line number Diff line
@@ -68,6 +68,12 @@ extern void tick_broadcast_control(enum tick_broadcast_mode mode); 
static inline void tick_broadcast_control(enum tick_broadcast_mode mode) { }

#endif /* BROADCAST */



#if defined(CONFIG_GENERIC_CLOCKEVENTS_BROADCAST) && defined(CONFIG_HOTPLUG_CPU)

extern void tick_offline_cpu(unsigned int cpu);

#else

static inline void tick_offline_cpu(unsigned int cpu) { }

#endif



#ifdef CONFIG_GENERIC_CLOCKEVENTS

extern int tick_broadcast_oneshot_control(enum tick_broadcast_state state);

#else

include/linux/time64.h

+21 −0
Original line number Diff line number Diff line
@@ -33,6 +33,17 @@ struct itimerspec64 { 
#define KTIME_MAX			((s64)~((u64)1 << 63))

#define KTIME_SEC_MAX			(KTIME_MAX / NSEC_PER_SEC)



/*

 * Limits for settimeofday():

 *

 * To prevent setting the time close to the wraparound point time setting

 * is limited so a reasonable uptime can be accomodated. Uptime of 30 years

 * should be really sufficient, which means the cutoff is 2232. At that

 * point the cutoff is just a small part of the larger problem.

 */

#define TIME_UPTIME_SEC_MAX		(30LL * 365 * 24 *3600)

#define TIME_SETTOD_SEC_MAX		(KTIME_SEC_MAX - TIME_UPTIME_SEC_MAX)



static inline int timespec64_equal(const struct timespec64 *a,

				   const struct timespec64 *b)

{
@@ -100,6 +111,16 @@ static inline bool timespec64_valid_strict(const struct timespec64 *ts) 
	return true;

}



static inline bool timespec64_valid_settod(const struct timespec64 *ts)

{

	if (!timespec64_valid(ts))

		return false;

	/* Disallow values which cause overflow issues vs. CLOCK_REALTIME */

	if ((unsigned long long)ts->tv_sec >= TIME_SETTOD_SEC_MAX)

		return false;

	return true;

}



/**

 * timespec64_to_ns - Convert timespec64 to nanoseconds

 * @ts:		pointer to the timespec64 variable to be converted

include/net/xfrm.h

+1 −1
Original line number Diff line number Diff line
@@ -219,7 +219,7 @@ struct xfrm_state { 
	struct xfrm_stats	stats;



	struct xfrm_lifetime_cur curlft;

	struct tasklet_hrtimer	mtimer;

	struct hrtimer		mtimer;



	struct xfrm_state_offload xso;

CRA Git | Maintained and supported by SUSTech CRA and CCSE