Commit a0db9c0a authored by sayli karnik's avatar sayli karnik Committed by Greg Kroah-Hartman
Browse files

staging: media: davinci_vpfe: Replace explicit NULL comparison with ! operator 



This patch replaces the explicit NULL comparisons with ! operator.
It was found using Coccinelle:

@disable is_null@
expression e;
@@
- e == NULL
+ !e

Signed-off-by: default avatarsayli karnik <karniksayli1995@gmail.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f9c7cb1c

drivers/staging/media/davinci_vpfe/vpfe_video.c

+7 −7
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ static struct media_entity *vpfe_get_input_entity 
	struct media_pad *remote;



	remote = media_entity_remote_pad(&vpfe_dev->vpfe_isif.pads[0]);

	if (remote == NULL) {

	if (!remote) {

		pr_err("Invalid media connection to isif/ccdc\n");

		return NULL;

	}
@@ -54,7 +54,7 @@ static int vpfe_update_current_ext_subdev(struct vpfe_video_device *video) 
	int i;



	remote = media_entity_remote_pad(&vpfe_dev->vpfe_isif.pads[0]);

	if (remote == NULL) {

	if (!remote) {

		pr_err("Invalid media connection to isif/ccdc\n");

		return -EINVAL;

	}
@@ -107,7 +107,7 @@ __vpfe_video_get_format(struct vpfe_video_device *video, 
	int ret;



	subdev = vpfe_video_remote_subdev(video, &pad);

	if (subdev == NULL)

	if (!subdev)

		return -EINVAL;



	fmt.which = V4L2_SUBDEV_FORMAT_ACTIVE;
@@ -236,7 +236,7 @@ static int vpfe_video_validate_pipeline(struct vpfe_pipeline *pipe) 
	 * format of the connected pad.

	 */

	subdev = vpfe_video_remote_subdev(pipe->outputs[0], NULL);

	if (subdev == NULL)

	if (!subdev)

		return -EPIPE;



	while (1) {
@@ -413,7 +413,7 @@ static int vpfe_open(struct file *file) 
	/* Allocate memory for the file handle object */

	handle = kzalloc(sizeof(struct vpfe_fh), GFP_KERNEL);



	if (handle == NULL)

	if (!handle)

		return -ENOMEM;



	v4l2_fh_init(&handle->vfh, &video->video_dev);
@@ -683,14 +683,14 @@ static int vpfe_enum_fmt(struct file *file, void *priv, 
	}

	/* get the remote pad */

	remote = media_entity_remote_pad(&video->pad);

	if (remote == NULL) {

	if (!remote) {

		v4l2_err(&vpfe_dev->v4l2_dev,

			 "invalid remote pad for video node\n");

		return -EINVAL;

	}

	/* get the remote subdev */

	subdev = vpfe_video_remote_subdev(video, NULL);

	if (subdev == NULL) {

	if (!subdev) {

		v4l2_err(&vpfe_dev->v4l2_dev,

			 "invalid remote subdev for video node\n");

		return -EINVAL;

CRA Git | Maintained and supported by SUSTech CRA and CCSE