Commit a0b54add authored Feb 10, 2014 by Rafael Aquini Committed by Linus Torvalds Feb 10, 2014

mm: fix page leak at nfs_symlink()



Changes in commit a0b8cab3 ("mm: remove lru parameter from
__pagevec_lru_add and remove parts of pagevec API") have introduced a
call to add_to_page_cache_lru() which causes a leak in nfs_symlink() as
now the page gets an extra refcount that is not dropped.

Jan Stancek observed and reported the leak effect while running test8
from Connectathon Testsuite.  After several iterations over the test
case, which creates several symlinks on a NFS mountpoint, the test
system was quickly getting into an out-of-memory scenario.

This patch fixes the page leak by dropping that extra refcount
add_to_page_cache_lru() is grabbing.

Signed-off-by: Jan Stancek <jstancek@redhat.com>
Signed-off-by: Rafael Aquini <aquini@redhat.com>
Acked-by: Mel Gorman <mgorman@suse.de>
Acked-by: Rik van Riel <riel@redhat.com>
Cc: Jeff Layton <jlayton@redhat.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: <stable@vger.kernel.org>	[3.11.x+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 1e4dd946

fs/nfs/dir.c

+5 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1846,6 +1846,11 @@ int nfs_symlink(struct inode dir, struct dentry dentry, const char *symname)
	GFP_KERNEL)) {		GFP_KERNEL)) {
	SetPageUptodate(page);		SetPageUptodate(page);
	unlock_page(page);		unlock_page(page);
			/*
			* add_to_page_cache_lru() grabs an extra page refcount.
			* Drop it here to avoid leaking this page later.
			*/
			page_cache_release(page);
	} else		} else
	__free_page(page);		__free_page(page);

Admin message