perf tools: Be consistent on the type of map->symbols[] interator (a0b2f5af) · Commits · 戴 / test

In a few cases we were using 'enum map_type' and that triggered this warning when using clang: util/session.c:1923:16: error: comparison of constant 2 with expression of type 'enum map_type' is always true [-Werror,-Wtautological-constant-out-of-range-compare] for (i = 0; i < MAP__NR_TYPES; ++i) { Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: David Ahern <dsahern@gmail.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Wang Nan <wangnan0@huawei.com> Link: http://lkml.kernel.org/n/tip-i6uyo6bsopa2dghnx8qo7rri@git.kernel.org Signed-off-by:

Arnaldo Carvalho de Melo <acme@redhat.com>

tools/perf/util/machine.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -782,7 +782,7 @@ static u64 machine__get_running_kernel_start(struct machine *machine,

		int __machine__create_kernel_maps(struct machine machine, struct dso kernel)
		{
		enum map_type type;
		int type;
		u64 start = machine__get_running_kernel_start(machine, NULL);

		/* In case of renewal the kernel map, destroy previous one */
		@@ -813,7 +813,7 @@ int __machine__create_kernel_maps(struct machine machine, struct dso kernel)

		void machine__destroy_kernel_maps(struct machine *machine)
		{
		enum map_type type;
		int type;

		for (type = 0; type < MAP__NR_TYPES; ++type) {
		struct kmap *kmap;

tools/perf/util/session.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1901,7 +1901,7 @@ int maps__set_kallsyms_ref_reloc_sym(struct map **maps,
		const char *symbol_name, u64 addr)
		{
		char *bracket;
		enum map_type i;
		int i;
		struct ref_reloc_sym *ref;

		ref = zalloc(sizeof(struct ref_reloc_sym));

Admin message