Commit a0ae04a2 authored Feb 20, 2020 by Leonard Crestez Committed by Stephen Boyd Mar 25, 2020

clk: imx: Align imx sc clock msg structs to 4



The imx SC api strongly assumes that messages are composed out of
4-bytes words but some of our message structs have odd sizeofs.

This produces many oopses with CONFIG_KASAN=y.

Fix by marking with __aligned(4).

Fixes: fe37b482 ("clk: imx: add scu clock common part")
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Link: https://lkml.kernel.org/r/10e97a04980d933b2cfecb6b124bf9046b6e4f16.1582216144.git.leonard.crestez@nxp.com


Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent 4e934301

drivers/clk/imx/clk-scu.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -43,12 +43,12 @@ struct imx_sc_msg_req_set_clock_rate {
		__le32 rate;
		__le16 resource;
		u8 clk;
		} __packed;
		} __packed __aligned(4);

		struct req_get_clock_rate {
		__le16 resource;
		u8 clk;
		} __packed;
		} __packed __aligned(4);

		struct resp_get_clock_rate {
		__le32 rate;
		@@ -121,7 +121,7 @@ struct imx_sc_msg_req_clock_enable {
		u8 clk;
		u8 enable;
		u8 autog;
		} __packed;
		} __packed __aligned(4);

		static inline struct clk_scu to_clk_scu(struct clk_hw hw)
		{

Admin message