Commit a09c5913 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

ACPI / LPSS: Avoid PM quirks on suspend and resume from S3 

It is reported that commit a192aa92 (ACPI / LPSS: Consolidate
runtime PM and system sleep handling) introduced a system suspend
regression on some machines, but the only functional change made by
it was to cause the PM quirks in the LPSS to also be used during
system suspend and resume.  While that should always work for
suspend-to-idle, it turns out to be problematic for S3
(suspend-to-RAM).

To address that issue restore the previous S3 suspend and resume
behavior of the LPSS to avoid applying PM quirks then.

Fixes: a192aa92 (ACPI / LPSS: Consolidate runtime PM and system sleep handling)
Link: https://bugs.launchpad.net/bugs/1774950


Reported-by: default avatarKai-Heng Feng <kai.heng.feng@canonical.com>
Tested-by: default avatarKai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Cc: 4.15+ <stable@vger.kernel.org> # 4.15+
parent d290ef93

drivers/acpi/acpi_lpss.c

+11 −7
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ 
#include <linux/pm_domain.h>

#include <linux/pm_runtime.h>

#include <linux/pwm.h>

#include <linux/suspend.h>

#include <linux/delay.h>



#include "internal.h"
@@ -944,9 +945,10 @@ static void lpss_iosf_exit_d3_state(void) 
	mutex_unlock(&lpss_iosf_mutex);

}



static int acpi_lpss_suspend(struct device *dev, bool wakeup)

static int acpi_lpss_suspend(struct device *dev, bool runtime)

{

	struct lpss_private_data *pdata = acpi_driver_data(ACPI_COMPANION(dev));

	bool wakeup = runtime || device_may_wakeup(dev);

	int ret;



	if (pdata->dev_desc->flags & LPSS_SAVE_CTX)
@@ -959,13 +961,14 @@ static int acpi_lpss_suspend(struct device *dev, bool wakeup) 
	 * wrong status for devices being about to be powered off. See

	 * lpss_iosf_enter_d3_state() for further information.

	 */

	if (lpss_quirks & LPSS_QUIRK_ALWAYS_POWER_ON && iosf_mbi_available())

	if ((runtime || !pm_suspend_via_firmware()) &&

	    lpss_quirks & LPSS_QUIRK_ALWAYS_POWER_ON && iosf_mbi_available())

		lpss_iosf_enter_d3_state();



	return ret;

}



static int acpi_lpss_resume(struct device *dev)

static int acpi_lpss_resume(struct device *dev, bool runtime)

{

	struct lpss_private_data *pdata = acpi_driver_data(ACPI_COMPANION(dev));

	int ret;
@@ -974,7 +977,8 @@ static int acpi_lpss_resume(struct device *dev) 
	 * This call is kept first to be in symmetry with

	 * acpi_lpss_runtime_suspend() one.

	 */

	if (lpss_quirks & LPSS_QUIRK_ALWAYS_POWER_ON && iosf_mbi_available())

	if ((runtime || !pm_resume_via_firmware()) &&

	    lpss_quirks & LPSS_QUIRK_ALWAYS_POWER_ON && iosf_mbi_available())

		lpss_iosf_exit_d3_state();



	ret = acpi_dev_resume(dev);
@@ -998,12 +1002,12 @@ static int acpi_lpss_suspend_late(struct device *dev) 
		return 0;



	ret = pm_generic_suspend_late(dev);

	return ret ? ret : acpi_lpss_suspend(dev, device_may_wakeup(dev));

	return ret ? ret : acpi_lpss_suspend(dev, false);

}



static int acpi_lpss_resume_early(struct device *dev)

{

	int ret = acpi_lpss_resume(dev);

	int ret = acpi_lpss_resume(dev, false);



	return ret ? ret : pm_generic_resume_early(dev);

}
@@ -1018,7 +1022,7 @@ static int acpi_lpss_runtime_suspend(struct device *dev) 


static int acpi_lpss_runtime_resume(struct device *dev)

{

	int ret = acpi_lpss_resume(dev);

	int ret = acpi_lpss_resume(dev, true);



	return ret ? ret : pm_generic_runtime_resume(dev);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE