Commit a088d1d7 authored Feb 03, 2017 by Linus Lüssing Committed by David S. Miller Feb 06, 2017

ipv6: Fix IPv6 packet loss in scenarios involving roaming + snooping switches



When for instance a mobile Linux device roams from one access point to
another with both APs sharing the same broadcast domain and a
multicast snooping switch in between:

1)    (c) <~~~> (AP1) <--[SSW]--> (AP2)

2)              (AP1) <--[SSW]--> (AP2) <~~~> (c)

Then currently IPv6 multicast packets will get lost for (c) until an
MLD Querier sends its next query message. The packet loss occurs
because upon roaming the Linux host so far stayed silent regarding
MLD and the snooping switch will therefore be unaware of the
multicast topology change for a while.

This patch fixes this by always resending MLD reports when an interface
change happens, for instance from NO-CARRIER to CARRIER state.

Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 62f01db9

net/ipv6/addrconf.c

+8 −2

Original line number	Original line	Diff line number	Diff line
	@@ -3386,9 +3386,15 @@ static int addrconf_notify(struct notifier_block *this, unsigned long event,
	}		}

	if (idev) {		if (idev) {
	if (idev->if_flags & IF_READY)		if (idev->if_flags & IF_READY) {
	/* device is already configured. */		/* device is already configured -
			* but resend MLD reports, we might
			* have roamed and need to update
			* multicast snooping switches
			*/
			ipv6_mc_up(idev);
	break;		break;
			}
	idev->if_flags \|= IF_READY;		idev->if_flags \|= IF_READY;
	}		}

Admin message