Commit a080da6a authored Apr 06, 2020 by Paul Blakey Committed by David S. Miller Apr 07, 2020

net: sched: Fix setting last executed chain on skb extension



After driver sets the missed chain on the tc skb extension it is
consumed (deleted) by tc_classify_ingress and tc jumps to that chain.
If tc now misses on this chain (either no match, or no goto action),
then last executed chain remains 0, and the skb extension is not re-added,
and the next datapath (ovs) will start from 0.

Fix that by setting last executed chain to the chain read from the skb
extension, so if there is a miss, we set it back.

Fixes: af699626 ("net: sched: Support specifying a starting chain via tc skb ext")
Reviewed-by: Oz Shlomo <ozsh@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Paul Blakey <paulb@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a4837980

net/sched/cls_api.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1667,6 +1667,7 @@ int tcf_classify_ingress(struct sk_buff *skb,
		skb_ext_del(skb, TC_SKB_EXT);

		tp = rcu_dereference_bh(fchain->filter_chain);
		last_executed_chain = fchain->index;
		}

		ret = __tcf_classify(skb, tp, orig_tp, res, compat_mode,

Admin message