Commit a050fa54 authored May 13, 2019 by Heyi Guo Committed by Marc Zyngier Jun 05, 2019

irqchip/gic-v3-its: Fix command queue pointer comparison bug



When we run several VMs with PCI passthrough and GICv4 enabled, not
pinning vCPUs, we will occasionally see below warnings in dmesg:

ITS queue timeout (65440 65504 480)
ITS cmd its_build_vmovp_cmd failed

The reason for the above issue is that in BUILD_SINGLE_CMD_FUNC:
1. Post the write command.
2. Release the lock.
3. Start to read GITS_CREADR to get the reader pointer.
4. Compare the reader pointer to the target pointer.
5. If reader pointer does not reach the target, sleep 1us and continue
to try.

If we have several processors running the above concurrently, other
CPUs will post write commands while the 1st CPU is waiting the
completion. So we may have below issue:

phase 1:
---rd_idx-----from_idx-----to_idx--0---------

wait 1us:

phase 2:
--------------from_idx-----to_idx--0-rd_idx--

That is the rd_idx may fly ahead of to_idx, and if in case to_idx is
near the wrap point, rd_idx will wrap around. So the below condition
will not be met even after 1s:

if (from_idx < to_idx && rd_idx >= to_idx)

There is another theoretical issue. For a slow and busy ITS, the
initial rd_idx may fall behind from_idx a lot, just as below:

---rd_idx---0--from_idx-----to_idx-----------

This will cause the wait function exit too early.

Actually, it does not make much sense to use from_idx to judge if
to_idx is wrapped, but we need a initial rd_idx when lock is still
acquired, and it can be used to judge whether to_idx is wrapped and
the current rd_idx is wrapped.

We switch to a method of calculating the delta of two adjacent reads
and accumulating it to get the sum, so that we can get the real rd_idx
from the wrapped value even when the queue is almost full.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Heyi Guo <guoheyi@huawei.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

parent 6d4d367d

drivers/irqchip/irq-gic-v3-its.c

+24 −11

Original line number	Diff line number	Diff line
		@@ -744,32 +744,43 @@ static void its_flush_cmd(struct its_node its, struct its_cmd_block cmd)
		}

		static int its_wait_for_range_completion(struct its_node *its,
		struct its_cmd_block *from,
		u64 prev_idx,
		struct its_cmd_block *to)
		{
		u64 rd_idx, from_idx, to_idx;
		u64 rd_idx, to_idx, linear_idx;
		u32 count = 1000000; /* 1s! */

		from_idx = its_cmd_ptr_to_offset(its, from);
		/* Linearize to_idx if the command set has wrapped around */
		to_idx = its_cmd_ptr_to_offset(its, to);
		if (to_idx < prev_idx)
		to_idx += ITS_CMD_QUEUE_SZ;

		linear_idx = prev_idx;

		while (1) {
		s64 delta;

		rd_idx = readl_relaxed(its->base + GITS_CREADR);

		/* Direct case */
		if (from_idx < to_idx && rd_idx >= to_idx)
		break;
		/*
		* Compute the read pointer progress, taking the
		* potential wrap-around into account.
		*/
		delta = rd_idx - prev_idx;
		if (rd_idx < prev_idx)
		delta += ITS_CMD_QUEUE_SZ;

		/* Wrapped case */
		if (from_idx >= to_idx && rd_idx >= to_idx && rd_idx < from_idx)
		linear_idx += delta;
		if (linear_idx >= to_idx)
		break;

		count--;
		if (!count) {
		pr_err_ratelimited("ITS queue timeout (%llu %llu %llu)\n",
		from_idx, to_idx, rd_idx);
		pr_err_ratelimited("ITS queue timeout (%llu %llu)\n",
		to_idx, linear_idx);
		return -1;
		}
		prev_idx = rd_idx;
		cpu_relax();
		udelay(1);
		}
		@@ -786,6 +797,7 @@ void name(struct its_node *its, \
		struct its_cmd_block cmd, sync_cmd, *next_cmd; \
		synctype *sync_obj; \
		unsigned long flags; \
		u64 rd_idx; \
		\
		raw_spin_lock_irqsave(&its->lock, flags); \
		\
		@@ -807,10 +819,11 @@ void name(struct its_node *its, \
		} \
		\
		post: \
		rd_idx = readl_relaxed(its->base + GITS_CREADR); \
		next_cmd = its_post_commands(its); \
		raw_spin_unlock_irqrestore(&its->lock, flags); \
		\
		if (its_wait_for_range_completion(its, cmd, next_cmd)) \
		if (its_wait_for_range_completion(its, rd_idx, next_cmd)) \
		pr_err_ratelimited("ITS cmd %ps failed\n", builder); \
		}

Admin message