Commit a0439342 authored Feb 05, 2016 by Ard Biesheuvel Committed by Michal Marek Feb 08, 2016

scripts/link-vmlinux.sh: force error on kallsyms failure



Since the output of the invocation of scripts/kallsyms is piped directly
into the assembler, error messages it emits are visible on stderr, but
a non-zero return code is ignored, and the build simply proceeds in that
case. However, the resulting kernel is most likely broken, and will crash
at boot.

So instead, capture the output of kallsyms in a separate .S file, and pass
that to the assembler in a separate step.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Michal Marek <mmarek@suse.com>

parent b41c29b0

scripts/link-vmlinux.sh

+4 −3

Original line number	Diff line number	Diff line
		@@ -93,9 +93,10 @@ kallsyms()
		local aflags="${KBUILD_AFLAGS} ${KBUILD_AFLAGS_KERNEL} \
		${NOSTDINC_FLAGS} ${LINUXINCLUDE} ${KBUILD_CPPFLAGS}"

		${NM} -n ${1} \| \
		scripts/kallsyms ${kallsymopt} \| \
		${CC} ${aflags} -c -o ${2} -x assembler-with-cpp -
		local afile="`basename ${2} .o`.S"

		${NM} -n ${1} \| scripts/kallsyms ${kallsymopt} > ${afile}
		${CC} ${aflags} -c -o ${2} ${afile}
		}

		# Create map file with all symbols from ${1}

Admin message