PCI: Add ACS quirk for APM X-Gene devices (a0418aa2) · Commits · 戴 / test

The APM X-Gene PCIe root port does not support ACS at this point. However, the hardware provides isolation and source validation through the SMMU. The stream ID generated by the PCIe ports contain both the bus/device/ function number as well as the port ID in its 3 most significant bits. Turn on ACS but disable all the peer-to-peer features. Signed-off-by:

Feng Kan <fkan@apm.com> Signed-off-by:

Bjorn Helgaas <bhelgaas@google.com> Reviewed-by:

Alex Williamson <alex.williamson@redhat.com> Acked-by:

Tanmay Inamdar <tinamdar@apm.com>

drivers/pci/quirks.c

+14 −0

Original line number	Diff line number	Diff line
		@@ -4137,6 +4137,18 @@ static int pci_quirk_cavium_acs(struct pci_dev *dev, u16 acs_flags)
		return acs_flags ? 0 : 1;
		}

		static int pci_quirk_xgene_acs(struct pci_dev *dev, u16 acs_flags)
		{
		/*
		* X-Gene root matching this quirk do not allow peer-to-peer
		* transactions with others, allowing masking out these bits as if they
		* were unimplemented in the ACS capability.
		*/
		acs_flags &= ~(PCI_ACS_SV \| PCI_ACS_RR \| PCI_ACS_CR \| PCI_ACS_UF);

		return acs_flags ? 0 : 1;
		}

		/*
		* Many Intel PCH root ports do provide ACS-like features to disable peer
		* transactions and validate bus numbers in requests, but do not provide an
		@@ -4385,6 +4397,8 @@ static const struct pci_dev_acs_enabled {
		{ 0x10df, 0x720, pci_quirk_mf_endpoint_acs }, /* Emulex Skyhawk-R */
		/* Cavium ThunderX */
		{ PCI_VENDOR_ID_CAVIUM, PCI_ANY_ID, pci_quirk_cavium_acs },
		/* APM X-Gene */
		{ PCI_VENDOR_ID_AMCC, 0xE004, pci_quirk_xgene_acs },
		{ 0 }
		};

Admin message