kgdb: have ebin2mem call probe_kernel_write once (a0279bd5) · Commits · 戴 / test

Rather than call probe_kernel_write() one byte at a time, process the whole buffer locally and pass the entire result in one go. This way, architectures that need to do special handling based on the length can do so, or we only end up calling memcpy() once. [sonic.zhang@analog.com: Reported original problem and preliminary patch] Signed-off-by:

Jason Wessel <jason.wessel@windriver.com> Signed-off-by:

Sonic Zhang <sonic.zhang@analog.com> Signed-off-by:

Mike Frysinger <vapier@gentoo.org>

kernel/kgdb.c

+9 −14

Original line number	Diff line number	Diff line
		@@ -391,27 +391,22 @@ int kgdb_mem2hex(char mem, char buf, int count)

		/*
		* Copy the binary array pointed to by buf into mem. Fix $, #, and
		* 0x7d escaped with 0x7d. Return a pointer to the character after
		* the last byte written.
		* 0x7d escaped with 0x7d. Return -EFAULT on failure or 0 on success.
		* The input buf is overwitten with the result to write to mem.
		*/
		static int kgdb_ebin2mem(char buf, char mem, int count)
		{
		int err = 0;
		char c;
		int size = 0;
		char *c = buf;

		while (count-- > 0) {
		c = *buf++;
		if (c == 0x7d)
		c = *buf++ ^ 0x20;

		err = probe_kernel_write(mem, &c, 1);
		if (err)
		break;

		mem++;
		c[size] = *buf++;
		if (c[size] == 0x7d)
		c[size] = *buf++ ^ 0x20;
		size++;
		}

		return err;
		return probe_kernel_write(mem, c, size);
		}

		/*

Admin message