Commit a0219d94 authored Sep 24, 2009 by Rusty Russell

cpumask: remove dangerous CPU_MASK_ALL_PTR



(Thanks to Al Viro for reminding me of this, via Ingo)

CPU_MASK_ALL is the (deprecated) "all bits set" cpumask, defined as so:

	#define CPU_MASK_ALL (cpumask_t) { { ... } }

Taking the address of such a temporary is questionable at best,
unfortunately 321a8e9d (cpumask: add CPU_MASK_ALL_PTR macro) added
CPU_MASK_ALL_PTR:

	#define CPU_MASK_ALL_PTR (&CPU_MASK_ALL)

Which formalizes this practice.  One day gcc could bite us over this
usage (though we seem to have gotten away with it so far).

Now all callers are removed, we kill it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Ingo Molnar <mingo@elte.hu>
Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: Mike Travis <travis@sgi.com>

parent 29c337a0

include/linux/cpumask.h

+0 −3

Original line number	Diff line number	Diff line
		@@ -324,8 +324,6 @@ static inline const struct cpumask *get_cpu_mask(unsigned int cpu)
		[BITS_TO_LONGS(NR_CPUS)-1] = CPU_MASK_LAST_WORD \
		} }

		#define CPU_MASK_ALL_PTR (&CPU_MASK_ALL)

		#else

		#define CPU_MASK_ALL \
		@@ -336,7 +334,6 @@ static inline const struct cpumask *get_cpu_mask(unsigned int cpu)

		/* cpu_mask_all is in init/main.c */
		extern cpumask_t cpu_mask_all;
		#define CPU_MASK_ALL_PTR (&cpu_mask_all)

		#endif

Admin message