Commit a01e718f authored Jun 07, 2016 by Al Viro

fix a regression in atomic_open()



open("/foo/no_such_file", O_RDONLY | O_CREAT) on should fail with
EACCES when /foo is not writable; failing with ENOENT is obviously
wrong.  That got broken by a braino introduced when moving the
creat_error logics from atomic_open() to lookup_open().  Easy to
fix, fortunately.

Spotted-by: "Yan, Zheng" <ukernel@gmail.com>
Tested-by: "Yan, Zheng" <ukernel@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 3d56c25e

fs/namei.c

+7 −3

Original line number	Diff line number	Diff line
		@@ -2995,11 +2995,15 @@ static int atomic_open(struct nameidata nd, struct dentry dentry,
		}
		if (*opened & FILE_CREATED)
		fsnotify_create(dir, dentry);
		if (unlikely(d_is_negative(dentry))) {
		error = -ENOENT;
		} else {
		path->dentry = dentry;
		path->mnt = nd->path.mnt;
		return 1;
		}
		}
		}
		dput(dentry);
		return error;
		}

Admin message