Commit a01a89b1 authored by Yejune Deng's avatar Yejune Deng Committed by Corey Minyard
Browse files

ipmi/watchdog: replace atomic_add() and atomic_sub() 



atomic_inc() and atomic_dec() looks better

Signed-off-by: default avatarYejune Deng <yejune.deng@gmail.com>
Message-Id: <1605511807-7135-1-git-send-email-yejune.deng@gmail.com>
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent 0df7b988

drivers/char/ipmi/ipmi_watchdog.c

+4 −4
Original line number Diff line number Diff line
@@ -495,7 +495,7 @@ static void panic_halt_ipmi_heartbeat(void) 
	msg.cmd = IPMI_WDOG_RESET_TIMER;

	msg.data = NULL;

	msg.data_len = 0;

	atomic_add(1, &panic_done_count);

	atomic_inc(&panic_done_count);

	rv = ipmi_request_supply_msgs(watchdog_user,

				      (struct ipmi_addr *) &addr,

				      0,
@@ -505,7 +505,7 @@ static void panic_halt_ipmi_heartbeat(void) 
				      &panic_halt_heartbeat_recv_msg,

				      1);

	if (rv)

		atomic_sub(1, &panic_done_count);

		atomic_dec(&panic_done_count);

}



static struct ipmi_smi_msg panic_halt_smi_msg = {
@@ -529,12 +529,12 @@ static void panic_halt_ipmi_set_timeout(void) 
	/* Wait for the messages to be free. */

	while (atomic_read(&panic_done_count) != 0)

		ipmi_poll_interface(watchdog_user);

	atomic_add(1, &panic_done_count);

	atomic_inc(&panic_done_count);

	rv = __ipmi_set_timeout(&panic_halt_smi_msg,

				&panic_halt_recv_msg,

				&send_heartbeat_now);

	if (rv) {

		atomic_sub(1, &panic_done_count);

		atomic_dec(&panic_done_count);

		pr_warn("Unable to extend the watchdog timeout\n");

	} else {

		if (send_heartbeat_now)

CRA Git | Maintained and supported by SUSTech CRA and CCSE