Unverified Commit a019ff3b authored by Andrei Vagin's avatar Andrei Vagin Committed by Christian Brauner
Browse files

selftests/clone3: check that all pids are released on error paths 



This is a regression test case for an issue when pids have not been
released on error paths.

Signed-off-by: default avatarAndrei Vagin <avagin@gmail.com>
Link: https://lore.kernel.org/r/20191118064750.408003-3-avagin@gmail.com


Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
parent 28df7515

tools/testing/selftests/clone3/clone3_set_tid.c

+14 −2
Original line number Diff line number Diff line
@@ -160,7 +160,7 @@ int main(int argc, char *argv[]) 
		ksft_exit_fail_msg("pipe() failed\n");



	ksft_print_header();

	ksft_set_plan(27);

	ksft_set_plan(29);



	f = fopen("/proc/sys/kernel/pid_max", "r");

	if (f == NULL)
@@ -290,6 +290,18 @@ int main(int argc, char *argv[]) 
	/* Let's create a PID 1 */

	ns_pid = fork();

	if (ns_pid == 0) {

		/*

		 * This and the next test cases check that all pid-s are

		 * released on error paths.

		 */

		set_tid[0] = 43;

		set_tid[1] = -1;

		test_clone3_set_tid(set_tid, 2, 0, -EINVAL, 0, 0);



		set_tid[0] = 43;

		set_tid[1] = pid;

		test_clone3_set_tid(set_tid, 2, 0, 0, 43, 0);



		ksft_print_msg("Child in PID namespace has PID %d\n", getpid());

		set_tid[0] = 2;

		test_clone3_set_tid(set_tid, 1, 0, 0, 2, 0);
@@ -366,7 +378,7 @@ int main(int argc, char *argv[]) 
	if (!WIFEXITED(status))

		ksft_test_result_fail("Child error\n");



	ksft_cnt.ksft_pass += 4 - (ksft_cnt.ksft_fail - WEXITSTATUS(status));

	ksft_cnt.ksft_pass += 6 - (ksft_cnt.ksft_fail - WEXITSTATUS(status));

	ksft_cnt.ksft_fail = WEXITSTATUS(status);



	if (ns3 == pid && ns2 == 42 && ns1 == 1)

CRA Git | Maintained and supported by SUSTech CRA and CCSE