net: phy: start state machine in phy_start only (a016becd) · Commits · 戴 / test

The state machine is a no-op before phy_start() has been called. Therefore let's enable it in phy_start() only. In phy_start() let's call phy_start_machine() instead of phy_trigger_machine(). phy_start_machine is an alias for phy_trigger_machine but it makes clearer that we start the state machine here instead of just triggering a run. Signed-off-by:

Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/phy/phy.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -878,7 +878,7 @@ void phy_start(struct phy_device *phydev)
		}
		mutex_unlock(&phydev->lock);

		phy_trigger_machine(phydev);
		phy_start_machine(phydev);
		}
		EXPORT_SYMBOL(phy_start);

drivers/net/phy/phy_device.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -951,7 +951,6 @@ int phy_connect_direct(struct net_device dev, struct phy_device phydev,
		return rc;

		phy_prepare_link(phydev, handler);
		phy_start_machine(phydev);
		if (phydev->irq > 0)
		phy_start_interrupts(phydev);

drivers/net/phy/phylink.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -676,7 +676,6 @@ static int phylink_bringup_phy(struct phylink pl, struct phy_device phy)
		__ETHTOOL_LINK_MODE_MASK_NBITS, pl->supported,
		__ETHTOOL_LINK_MODE_MASK_NBITS, phy->advertising);

		phy_start_machine(phy);
		if (phy->irq > 0)
		phy_start_interrupts(phy);

Admin message