Commit 9feffe14 authored Aug 01, 2020 by Zhihao Cheng Committed by Jaegeuk Kim Aug 03, 2020

f2fs: update_sit_entry: Make the judgment condition of f2fs_bug_on more intuitive



Current judgment condition of f2fs_bug_on in function update_sit_entry():
  new_vblocks >> (sizeof(unsigned short) << 3) ||
	new_vblocks > sbi->blocks_per_seg

which equivalents to:
  new_vblocks < 0 || new_vblocks > sbi->blocks_per_seg

The latter is more intuitive.

Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Reported-by: Jack Qiu <jack.qiu@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

parent 58f7e00f

fs/f2fs/segment.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2166,7 +2166,7 @@ static void update_sit_entry(struct f2fs_sb_info *sbi, block_t blkaddr, int del)
		new_vblocks = se->valid_blocks + del;
		offset = GET_BLKOFF_FROM_SEG0(sbi, blkaddr);

		f2fs_bug_on(sbi, (new_vblocks >> (sizeof(unsigned short) << 3) \|\|
		f2fs_bug_on(sbi, (new_vblocks < 0 \|\|
		(new_vblocks > sbi->blocks_per_seg)));

		se->valid_blocks = new_vblocks;

Admin message