Unverified Commit 9fe26adb authored Oct 02, 2020 by Łukasz Stelmach Committed by Mark Brown Oct 02, 2020

spi: spi-s3c64xx: Increase transfer timeout



Increase timeout by 30 ms for some wiggle room and set the minimum value
to 100 ms. This ensures a non-zero value for short transfers which
may take less than 1 ms. The timeout value does not affect
performance because it is used with a completion.

Similar formula is used in other drivers e.g. sun4i, sun6i.

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
Link: https://lore.kernel.org/r/20201002122243.26849-9-l.stelmach@samsung.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 20b4016a

drivers/spi/spi-s3c64xx.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -473,7 +473,8 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd,

		/* millisecs to xfer 'len' bytes @ 'cur_speed' */
		ms = xfer->len * 8 * 1000 / sdd->cur_speed;
		ms += 10; /* some tolerance */
		ms += 30; /* some tolerance */
		ms = max(ms, 100); /* minimum timeout */

		val = msecs_to_jiffies(ms) + 10;
		val = wait_for_completion_timeout(&sdd->xfer_completion, val);

Admin message