Commit 9fc41acc authored Sep 23, 2019 by Valentin Schneider Committed by Ingo Molnar Sep 25, 2019

sched/core: Remove double update_max_interval() call on CPU startup



update_max_interval() is called in both CPUHP_AP_SCHED_STARTING's startup
and teardown callbacks, but it turns out it's also called at the end of
the startup callback of CPUHP_AP_ACTIVE (which is further down the
startup sequence).

There's no point in repeating this interval update in the startup sequence
since the CPU will remain online until it goes down the teardown path.

Remove the redundant call in sched_cpu_activate() (CPUHP_AP_ACTIVE).

Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: dietmar.eggemann@arm.com
Cc: juri.lelli@redhat.com
Cc: vincent.guittot@linaro.org
Link: https://lkml.kernel.org/r/20190923093017.11755-1-valentin.schneider@arm.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent a49b4f40

kernel/sched/core.c

+0 −2

Original line number	Original line	Diff line number	Diff line
	@@ -6425,8 +6425,6 @@ int sched_cpu_activate(unsigned int cpu)
	}		}
	rq_unlock_irqrestore(rq, &rf);		rq_unlock_irqrestore(rq, &rf);

	update_max_interval();

	return 0;		return 0;
	}		}

Admin message