Commit 9fb10671 authored by Aditya Pakki's avatar Aditya Pakki Committed by Alex Deucher
Browse files

drm/radeon: Fix reference count leaks caused by pm_runtime_get_sync 



On calling pm_runtime_get_sync() the reference count of the device
is incremented. In case of failure, decrement the
reference count before returning the error.

Acked-by: default avatarEvan Quan <evan.quan@amd.com>
Signed-off-by: default avatarAditya Pakki <pakki001@umn.edu>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent f79f9476

drivers/gpu/drm/radeon/radeon_display.c

+3 −1
Original line number Diff line number Diff line
@@ -635,8 +635,10 @@ radeon_crtc_set_config(struct drm_mode_set *set, 
	dev = set->crtc->dev;



	ret = pm_runtime_get_sync(dev->dev);

	if (ret < 0)

	if (ret < 0) {

		pm_runtime_put_autosuspend(dev->dev);

		return ret;

	}



	ret = drm_crtc_helper_set_config(set, ctx);

drivers/gpu/drm/radeon/radeon_drv.c

+3 −1
Original line number Diff line number Diff line
@@ -544,8 +544,10 @@ long radeon_drm_ioctl(struct file *filp, 
	long ret;

	dev = file_priv->minor->dev;

	ret = pm_runtime_get_sync(dev->dev);

	if (ret < 0)

	if (ret < 0) {

		pm_runtime_put_autosuspend(dev->dev);

		return ret;

	}



	ret = drm_ioctl(filp, cmd, arg);

drivers/gpu/drm/radeon/radeon_kms.c

+3 −1
Original line number Diff line number Diff line
@@ -638,8 +638,10 @@ int radeon_driver_open_kms(struct drm_device *dev, struct drm_file *file_priv) 
	file_priv->driver_priv = NULL;



	r = pm_runtime_get_sync(dev->dev);

	if (r < 0)

	if (r < 0) {

		pm_runtime_put_autosuspend(dev->dev);

		return r;

	}



	/* new gpu have virtual address space support */

	if (rdev->family >= CHIP_CAYMAN) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE