Commit 9f885201 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by David S. Miller
Browse files

IB/mlx5: Reorder code in query device command 



The order of features exposed by private mlx5-abi.h
file is CQE zipping, packet pacing and multi-packet WQE.

The internal order implemented in mlx5_ib_query_device() is
multi-packet WQE, CQE zipping and packet pacing.

Such difference hurts code readability, so let's sync,
while mlx5-abi.h (exposed to userspace) is the primary
order.

This commit doesn't change any functionality.

Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7b13558f

drivers/infiniband/hw/mlx5/main.c

+11 −11
Original line number Diff line number Diff line
@@ -672,17 +672,6 @@ static int mlx5_ib_query_device(struct ib_device *ibdev, 
			1 << MLX5_CAP_GEN(dev->mdev, log_max_rq);

	}



	if (field_avail(typeof(resp), mlx5_ib_support_multi_pkt_send_wqes,

			uhw->outlen)) {

		resp.mlx5_ib_support_multi_pkt_send_wqes =

			MLX5_CAP_ETH(mdev, multi_pkt_send_wqe);

		resp.response_length +=

			sizeof(resp.mlx5_ib_support_multi_pkt_send_wqes);

	}



	if (field_avail(typeof(resp), reserved, uhw->outlen))

		resp.response_length += sizeof(resp.reserved);



	if (field_avail(typeof(resp), cqe_comp_caps, uhw->outlen)) {

		resp.cqe_comp_caps.max_num =

			MLX5_CAP_GEN(dev->mdev, cqe_compression) ?
@@ -706,6 +695,17 @@ static int mlx5_ib_query_device(struct ib_device *ibdev, 
		resp.response_length += sizeof(resp.packet_pacing_caps);

	}



	if (field_avail(typeof(resp), mlx5_ib_support_multi_pkt_send_wqes,

			uhw->outlen)) {

		resp.mlx5_ib_support_multi_pkt_send_wqes =

			MLX5_CAP_ETH(mdev, multi_pkt_send_wqe);

		resp.response_length +=

			sizeof(resp.mlx5_ib_support_multi_pkt_send_wqes);

	}



	if (field_avail(typeof(resp), reserved, uhw->outlen))

		resp.response_length += sizeof(resp.reserved);



	if (uhw->outlen) {

		err = ib_copy_to_udata(uhw, &resp, resp.response_length);

CRA Git | Maintained and supported by SUSTech CRA and CCSE