Commit 9f754657 authored Jul 06, 2019 by Nishka Dasgupta Committed by Guenter Roeck Jul 08, 2019

hwmon: (ina3221) Add of_node_put() before return



Each iteration of for_each_child_of_node puts the previous
node, but in the case of a return from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
return.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190706132130.3129-1-nishkadg.linux@gmail.com


Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 277c628f

drivers/hwmon/ina3221.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -713,9 +713,11 @@ static int ina3221_probe_from_dt(struct device dev, struct ina3221_data ina)

		for_each_child_of_node(np, child) {
		ret = ina3221_probe_child_from_dt(dev, child, ina);
		if (ret)
		if (ret) {
		of_node_put(child);
		return ret;
		}
		}

		return 0;
		}

Admin message