Commit 9f70f46b authored by Neil Horman's avatar Neil Horman Committed by David S. Miller
Browse files

sctp: properly latch and use autoclose value from sock to association 



Currently, sctp associations latch a sockets autoclose value to an association
at association init time, subject to capping constraints from the max_autoclose
sysctl value.  This leads to an odd situation where an application may set a
socket level autoclose timeout, but sliently sctp will limit the autoclose
timeout to something less than that.

Fix this by modifying the autoclose setsockopt function to check the limit, cap
it and warn the user via syslog that the timeout is capped.  This will allow
getsockopt to return valid autoclose timeout values that reflect what subsequent
associations actually use.

While were at it, also elimintate the assoc->autoclose variable, it duplicates
whats in the timeout array, which leads to multiple sources for the same
information, that may differ (as the former isn't subject to any capping).  This
gives us the timeout information in a canonical place and saves some space in
the association structure as well.

Signed-off-by: default avatarNeil Horman <nhorman@tuxdriver.com>
Acked-by: default avatarVlad Yasevich <vyasevich@gmail.com>
CC: Wang Weidong <wangweidong1@huawei.com>
CC: David Miller <davem@davemloft.net>
CC: Vlad Yasevich <vyasevich@gmail.com>
CC: netdev@vger.kernel.org
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 231df15f

include/net/sctp/structs.h

+0 −6
Original line number Diff line number Diff line
@@ -1726,12 +1726,6 @@ struct sctp_association { 
	/* How many duplicated TSNs have we seen?  */

	int numduptsns;



	/* Number of seconds of idle time before an association is closed.

	 * In the association context, this is really used as a boolean

	 * since the real timeout is stored in the timeouts array

	 */

	__u32 autoclose;



	/* These are to support

	 * "SCTP Extensions for Dynamic Reconfiguration of IP Addresses

	 *  and Enforcement of Flow and Message Limits"

net/sctp/associola.c

+1 −4
Original line number Diff line number Diff line
@@ -154,8 +154,7 @@ static struct sctp_association *sctp_association_init(struct sctp_association *a 


	asoc->timeouts[SCTP_EVENT_TIMEOUT_HEARTBEAT] = 0;

	asoc->timeouts[SCTP_EVENT_TIMEOUT_SACK] = asoc->sackdelay;

	asoc->timeouts[SCTP_EVENT_TIMEOUT_AUTOCLOSE] =

		min_t(unsigned long, sp->autoclose, net->sctp.max_autoclose) * HZ;

	asoc->timeouts[SCTP_EVENT_TIMEOUT_AUTOCLOSE] = sp->autoclose * HZ;



	/* Initializes the timers */

	for (i = SCTP_EVENT_TIMEOUT_NONE; i < SCTP_NUM_TIMEOUT_TYPES; ++i)
@@ -291,8 +290,6 @@ static struct sctp_association *sctp_association_init(struct sctp_association *a 
		asoc->peer.ipv6_address = 1;

	INIT_LIST_HEAD(&asoc->asocs);



	asoc->autoclose = sp->autoclose;



	asoc->default_stream = sp->default_stream;

	asoc->default_ppid = sp->default_ppid;

	asoc->default_flags = sp->default_flags;

net/sctp/output.c

+2 −1
Original line number Diff line number Diff line
@@ -581,7 +581,8 @@ int sctp_packet_transmit(struct sctp_packet *packet) 
		unsigned long timeout;



		/* Restart the AUTOCLOSE timer when sending data. */

		if (sctp_state(asoc, ESTABLISHED) && asoc->autoclose) {

		if (sctp_state(asoc, ESTABLISHED) &&

		    asoc->timeouts[SCTP_EVENT_TIMEOUT_AUTOCLOSE]) {

			timer = &asoc->timers[SCTP_EVENT_TIMEOUT_AUTOCLOSE];

			timeout = asoc->timeouts[SCTP_EVENT_TIMEOUT_AUTOCLOSE];

net/sctp/sm_statefuns.c

+6 −6
Original line number Diff line number Diff line
@@ -820,7 +820,7 @@ sctp_disposition_t sctp_sf_do_5_1D_ce(struct net *net, 
	SCTP_INC_STATS(net, SCTP_MIB_PASSIVEESTABS);

	sctp_add_cmd_sf(commands, SCTP_CMD_HB_TIMERS_START, SCTP_NULL());



	if (new_asoc->autoclose)

	if (new_asoc->timeouts[SCTP_EVENT_TIMEOUT_AUTOCLOSE])

		sctp_add_cmd_sf(commands, SCTP_CMD_TIMER_START,

				SCTP_TO(SCTP_EVENT_TIMEOUT_AUTOCLOSE));
@@ -908,7 +908,7 @@ sctp_disposition_t sctp_sf_do_5_1E_ca(struct net *net, 
	SCTP_INC_STATS(net, SCTP_MIB_CURRESTAB);

	SCTP_INC_STATS(net, SCTP_MIB_ACTIVEESTABS);

	sctp_add_cmd_sf(commands, SCTP_CMD_HB_TIMERS_START, SCTP_NULL());

	if (asoc->autoclose)

	if (asoc->timeouts[SCTP_EVENT_TIMEOUT_AUTOCLOSE])

		sctp_add_cmd_sf(commands, SCTP_CMD_TIMER_START,

				SCTP_TO(SCTP_EVENT_TIMEOUT_AUTOCLOSE));
@@ -2970,7 +2970,7 @@ sctp_disposition_t sctp_sf_eat_data_6_2(struct net *net, 
	if (chunk->chunk_hdr->flags & SCTP_DATA_SACK_IMM)

		force = SCTP_FORCE();



	if (asoc->autoclose) {

	if (asoc->timeouts[SCTP_EVENT_TIMEOUT_AUTOCLOSE]) {

		sctp_add_cmd_sf(commands, SCTP_CMD_TIMER_RESTART,

				SCTP_TO(SCTP_EVENT_TIMEOUT_AUTOCLOSE));

	}
@@ -3878,7 +3878,7 @@ sctp_disposition_t sctp_sf_eat_fwd_tsn(struct net *net, 
				SCTP_CHUNK(chunk));



	/* Count this as receiving DATA. */

	if (asoc->autoclose) {

	if (asoc->timeouts[SCTP_EVENT_TIMEOUT_AUTOCLOSE]) {

		sctp_add_cmd_sf(commands, SCTP_CMD_TIMER_RESTART,

				SCTP_TO(SCTP_EVENT_TIMEOUT_AUTOCLOSE));

	}
@@ -5267,7 +5267,7 @@ sctp_disposition_t sctp_sf_do_9_2_start_shutdown( 
	sctp_add_cmd_sf(commands, SCTP_CMD_TIMER_RESTART,

			SCTP_TO(SCTP_EVENT_TIMEOUT_T5_SHUTDOWN_GUARD));



	if (asoc->autoclose)

	if (asoc->timeouts[SCTP_EVENT_TIMEOUT_AUTOCLOSE])

		sctp_add_cmd_sf(commands, SCTP_CMD_TIMER_STOP,

				SCTP_TO(SCTP_EVENT_TIMEOUT_AUTOCLOSE));
@@ -5346,7 +5346,7 @@ sctp_disposition_t sctp_sf_do_9_2_shutdown_ack( 
	sctp_add_cmd_sf(commands, SCTP_CMD_TIMER_RESTART,

			SCTP_TO(SCTP_EVENT_TIMEOUT_T2_SHUTDOWN));



	if (asoc->autoclose)

	if (asoc->timeouts[SCTP_EVENT_TIMEOUT_AUTOCLOSE])

		sctp_add_cmd_sf(commands, SCTP_CMD_TIMER_STOP,

				SCTP_TO(SCTP_EVENT_TIMEOUT_AUTOCLOSE));

net/sctp/socket.c

+4 −0
Original line number Diff line number Diff line
@@ -2196,6 +2196,7 @@ static int sctp_setsockopt_autoclose(struct sock *sk, char __user *optval, 
				     unsigned int optlen)

{

	struct sctp_sock *sp = sctp_sk(sk);

	struct net *net = sock_net(sk);



	/* Applicable to UDP-style socket only */

	if (sctp_style(sk, TCP))
@@ -2205,6 +2206,9 @@ static int sctp_setsockopt_autoclose(struct sock *sk, char __user *optval, 
	if (copy_from_user(&sp->autoclose, optval, optlen))

		return -EFAULT;



	if (sp->autoclose > net->sctp.max_autoclose)

		sp->autoclose = net->sctp.max_autoclose;



	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE