Commit 9f6ed032 authored Jun 16, 2016 by Daniel Borkmann Committed by David S. Miller Jun 16, 2016

net, cls: also reject deleting all filters when TCA_KIND present

When we check for RTM_DELTFILTER, we should also reject the request
for deleting all filters under a given parent when TCA_KIND attribute
is present. If present, it's currently just ignored but there's also
no point to let it pass in the first place either since this doesn't
have any meaning with wild-card removal.

Fixes: ea7f8277 ("net, cls: allow for deleting all filters for given parent")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5b706e5c

net/sched/cls_api.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -169,7 +169,7 @@ replay:
		if (prio == 0) {
		switch (n->nlmsg_type) {
		case RTM_DELTFILTER:
		if (protocol \|\| t->tcm_handle)
		if (protocol \|\| t->tcm_handle \|\| tca[TCA_KIND])
		return -ENOENT;
		break;
		case RTM_NEWTFILTER:

Admin message