Commit 9f645bcc authored May 11, 2018 by Kees Cook

video: uvesafb: Fix integer overflow in allocation



cmap->len can get close to INT_MAX/2, allowing for an integer overflow in
allocation. This uses kmalloc_array() instead to catch the condition.

Reported-by: Dr Silvio Cesare of InfoSect <silvio.cesare@gmail.com>
Fixes: 8bdb3a2d ("uvesafb: the driver core")
Cc: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>

parent 353748a3

drivers/video/fbdev/uvesafb.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1044,7 +1044,8 @@ static int uvesafb_setcmap(struct fb_cmap cmap, struct fb_info info)
		info->cmap.len \|\| cmap->start < info->cmap.start)
		return -EINVAL;

		entries = kmalloc(sizeof(entries) cmap->len, GFP_KERNEL);
		entries = kmalloc_array(cmap->len, sizeof(*entries),
		GFP_KERNEL);
		if (!entries)
		return -ENOMEM;

Admin message